Skip to content

mts targets: fix debug() usage #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2017
Merged

mts targets: fix debug() usage #5032

merged 1 commit into from
Sep 27, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 6, 2017

Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes #5013

@janjongboom @sg- @mfiore02

@janjongboom
Copy link
Contributor

@0xc0170 Can we also get rid of the macro in targets/TARGET_STM/TARGET_STM32L1/TARGET_XDOT_L151CC/xdot_low_power.c then please?

@0xc0170
mts targets: fix debug() usage
52f8481 
Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes ARMmbed#5013
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 6, 2017

@0xc0170 Can we also get rid of the macro in targets/TARGET_STM/TARGET_STM32L1/TARGET_XDOT_L151CC/xdot_low_power.c then please?

Fixed

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 6, 2017

cc @jeromecoutant quick review, as you have touched all these targets

@bulislaw
Copy link
Member

bulislaw commented Sep 7, 2017

As @maciejbocianski noticed that will never print anything as DEVICE_STDIO_MESSAGES is not defined anywhere.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 7, 2017

As @maciejbocianski noticed that will never print anything as DEVICE_STDIO_MESSAGES is not defined anywhere.

It's part of the targets config (https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L61). We use this in couple of places at the moment (retarget, error, debug). It should be functional.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 7, 2017

retest uvisor

@bulislaw
Copy link
Member

bulislaw commented Sep 7, 2017

Ah yes! it's STDIO_MESSAGES in there ... ofc

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 27, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1398

All builds and test passed!

theotherjimmy
theotherjimmy approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @jeromecoutant

@theotherjimmy theotherjimmy merged commit c24fed1 into ARMmbed:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @janjongboom @bulislaw @mbed-bot @theotherjimmy @jeromecoutant