-
Notifications
You must be signed in to change notification settings - Fork 3k
Export uVision linker flags so that bootloader projects build correctly #5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 👏
Wonderful.
Thanks for writing this patch!
/morph export-build |
@chrissnow What is the current behavior without these flags? How to reproduce this issue? |
It will build but will be linked to the defaults in the linker script. Which would be where the bootlooader lives. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 135 Exporter Build failed! |
:-( Please could someone share the reason it failed. |
IAR died hard. @studavekar The CI should be able to find iccarm and the other tools in the path for executing the make_iar exporter. Could a machine switch have caused the boat load of IAR error here? |
@chrissnow It looks like your patch is working, well not breaking CI (no uVision failures at all), and we need to repair the IAR installation or something like that. |
One of the machine didn't had path set, re-triggering /morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 136 All exports and builds passed! |
Description
Bootloader projects require DMBED_APP_START and DMBED_APP_SIZE flags passing to the linker, CLI does this but export did not.
Status
READY
Migrations
NO
Related PRs
Deploy notes
Steps to test or reproduce
Export a bootloader project and it does not have the linker flags set.