SAM_CortexM0P uses uninitialized memory in i2c and uses out of bounds array in pwmout #4852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Aug 3, 2017
|
Can you update the commit message (maximum 50 characters) otherwise it wraps around as you can spot here. |
|
More or less off topic but can somebody bump Microchip/Atmel to get SAM support for mbedOS 5? |
|
/morph test |
Uses uninitialized memory in I2C, and accesses an out of band array in pwmout
janjongboom
force-pushed
the
cortexm0p_bugs
branch
from
2b9c30f to
f9d0304
Compare
|
0xc0170 pushed new commit message |
0xc0170
approved these changes
Aug 7, 2017
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know these are mbed 2 targets, but I still think we should fix these bugs.
Found them using cppcheck.