-
Notifications
You must be signed in to change notification settings - Fork 3k
Updating mbed-coap to version 4.0.8 #4833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yogpan01 We use the PR titles is release notes, and I would not expect anyone to know what anything IOTCLT-* means. Could you update the title to reflect what you're fixing? |
Same for the commit message 👍 |
@0xc0170 I have updated the PR title, the PR is fix for the issues reported in Github and I have updated the issue number in the title as well as in comment section. |
@yogpan01 We recommend that you describe what you are fixing instead of referencing issues, as this is easier to understand it the release notes. Could you add a short description of what you are fixing in the title and commit messages instead of the issue numbers? It looks like you updated the |
Can you please update? We will then start the CI |
@anttiylitokola Can you please update the PR title and description as requested by @0xc0170 ? |
@yogpan01, This data is coming from your own fork so I do not have rights to update anything here. |
@0xc0170 I have updated the title and also added some information about the actual issues that were fixed in description. Is this ok now ? |
Almost, the most important part is being it part of the commit (github description then can be the same). if you can ammend the commit to include that info, would be appreciated. helps a lot |
Fixes errors reported in Github - ARMmbed#4798 - Fixed Lwm2m blockwise data transfer (using Block1 option) with Leshan - ARMmbed/mbed-client#512 - Fixed an ongoing blocktransfer (Block 1 option) interruption by out of order Block to return error 4.08 Request Entity Incomplete as specified in the coap specification. - ARMmbed/mbed-client#511 - Fixed detected duplicate message duplications will not stop mbed-client
@0xc0170 Done the update on the commit. Please let me know, if this is fine now. |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
Fixes errors reported in Github
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Related PRs
List related PRs against other branches:
PelionIoT/mbed-coap#29
PelionIoT/mbed-coap#28
PelionIoT/mbed-coap#25