Skip to content

Updating mbed-coap to version 4.0.8 #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

yogpan01
Copy link
Contributor

@yogpan01 yogpan01 commented Jul 31, 2017

Description

Fixes errors reported in Github

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

List related PRs against other branches:
PelionIoT/mbed-coap#29
PelionIoT/mbed-coap#28
PelionIoT/mbed-coap#25

@yogpan01 yogpan01 changed the title Fixes for IOTCLT-1885, IOTCLt-1880 Fixes for IOTCLT-1885, IOTCLT-1880 Jul 31, 2017
@theotherjimmy
Copy link
Contributor

@yogpan01 We use the PR titles is release notes, and I would not expect anyone to know what anything IOTCLT-* means. Could you update the title to reflect what you're fixing?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2017

@yogpan01 We use the PR titles is release notes, and I would not expect anyone to know what anything IOTCLT-* means. Could you update the title to reflect what you're fixing?

Same for the commit message 👍

@yogpan01 yogpan01 changed the title Fixes for IOTCLT-1885, IOTCLT-1880 Fixes for IOTCLT-1885, IOTCLT-1880, IOTCLT-1883 Aug 1, 2017
@yogpan01 yogpan01 changed the title Fixes for IOTCLT-1885, IOTCLT-1880, IOTCLT-1883 Fixes for mbed-coap issues #4798 , mbed-client issue - 512, 511 Aug 1, 2017
@yogpan01
Copy link
Contributor Author

yogpan01 commented Aug 1, 2017

@0xc0170 I have updated the PR title, the PR is fix for the issues reported in Github and I have updated the issue number in the title as well as in comment section.

@theotherjimmy
Copy link
Contributor

@yogpan01 We recommend that you describe what you are fixing instead of referencing issues, as this is easier to understand it the release notes. Could you add a short description of what you are fixing in the title and commit messages instead of the issue numbers? It looks like you updated the mbed-coap library, so something like Update mbed-coap to version 4.0.8 might be easier to understand.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 7, 2017

@yogpan01 We recommend that you describe what you are fixing instead of referencing issues, as this is easier to understand it the release notes. Could you add a short description of what you are fixing in the title and commit messages instead of the issue numbers? It looks like you updated the mbed-coap library, so something like Update mbed-coap to version 4.0.8 might be easier to understand.

Can you please update? We will then start the CI

@yogpan01
Copy link
Contributor Author

yogpan01 commented Aug 8, 2017

@anttiylitokola Can you please update the PR title and description as requested by @0xc0170 ?

@anttiylitokola
Copy link
Contributor

anttiylitokola commented Aug 8, 2017

@yogpan01, This data is coming from your own fork so I do not have rights to update anything here.

@yogpan01 yogpan01 changed the title Fixes for mbed-coap issues #4798 , mbed-client issue - 512, 511 Updating mbed-coap to version 4.0.8 Aug 8, 2017
@yogpan01
Copy link
Contributor Author

yogpan01 commented Aug 8, 2017

@0xc0170 I have updated the title and also added some information about the actual issues that were fixed in description. Is this ok now ?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2017

@0xc0170 I have updated the title and also added some information about the actual issues that were fixed in description. Is this ok now ?

Almost, the most important part is being it part of the commit (github description then can be the same). if you can ammend the commit to include that info, would be appreciated. helps a lot

Fixes errors reported in Github

 - ARMmbed#4798
   - Fixed Lwm2m blockwise data transfer (using Block1 option) with Leshan
 - ARMmbed/mbed-client#512
   - Fixed an ongoing blocktransfer (Block 1 option) interruption by out of order Block to return error 4.08 Request Entity Incomplete as specified in the coap specification.
 - ARMmbed/mbed-client#511
   - Fixed detected duplicate message duplications will not stop mbed-client
@yogpan01
Copy link
Contributor Author

yogpan01 commented Aug 8, 2017

@0xc0170 Done the update on the commit. Please let me know, if this is fine now.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Aug 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 963

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants