fix unresolved linker msg: __wrap_ #4822
Conversation
|
@theotherjimmy finally... from a fresh forked repo. |
tools/export/makefile/__init__.py
Outdated
| @@ -200,7 +200,7 @@ class GccArm(Makefile): | |||
|
|
|||
| @staticmethod | |||
| def prepare_lib(libname): | |||
| return "-l:" + libname | |||
| return "-l" + libname[3:-2] | |||
There was a problem hiding this comment.
Could we check for the lib prefix here before we strip it? Don't worry about the .a suffix, it's gaurenteed.
There was a problem hiding this comment.
Isn't the name generated by prefix + name + suffix because its a gcc naming convention? And what to assume when the prefix is not 'lib'?
There was a problem hiding this comment.
It should be, but you can easily generate a library by using the ar command yourself that does not follow the standard. I think there are versions of mbed OS 5 and 2 that contain libraries that do not conform (It won't happen in the future, we have a Travis CI check to prevent that now). It should be pretty safe to add that check.
|
NICE! You got it working, and the diff looks correct! |
|
This should actually fix the eclipse_gcc_arm exporter too! |
|
/morph export-build |
|
Travis, what are you doing?! How can you succed with PIP but fail to load the python modlue you just installed! Just expressing frustration unrelated to this PR, But we will have to rebuild in travis. |
|
The travis should be fixed on master. @JojoS62 Can you please rebase? |
|
@theotherjimmy what have I to do for the rebase? |
|
@JojoS62 You should pull down the latest armmbed master and rebase your branch onto it. For example (with
|
adding libraries to gcc linker group command
JojoS62
force-pushed
the
fix-makefile-exporter
branch
from
078608d to
0c25444
Compare
|
ok, something happend. |
|
@JojoS62 That looks correct! and Travis CI Passed!
|
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 115 Exporter Build failed! |
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 117 All exports and builds passed! |
Description
Issue #3673
The make_gcc_arm exporter for mbed os 2 fails with linker errors for wrapper functions. These can be fixed by adding the libraries to the linker group
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
Steps to test or reproduce
import mbed classic program
mbed export -i make_gcc_arm
make
will fail with messages like: