Fix non-portable defines #4775
Merged
Fix non-portable defines #4775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A define which expands to more defines is not portable across all compilers and GCC warns about this. Restructure this so the behavior is defined. This fixes the GCC warning: "this use of "defined" may not be portable"
|
/morph test |
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Jul 19, 2017
|
@tommikas Few recent PR fails, is it known? |
|
I restarted jenkins CI. There wa sa known problem with one device, that was fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A define which expands to more defines is not portable across all compilers and GCC warns about this. Restructure this so the behavior is defined. This fixes the GCC warning:
"this use of "defined" may not be portable"