RTOS: Mutex: Rework tests #4729
Conversation
|
/morph test |
bulislaw
force-pushed
the
mutex_tests
branch
2 times, most recently
from
05ed1dd to
fd4c31a
Compare
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest Prep failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
They sort of are, it's an old test, that probably could be removed, but the variables you mentioned are manipulated inside the mutex protected zone and only if the mutex wouldn't work properly something 'bad' would happen. |
|
@bulislaw Those tests target mutexes behaviors. It shouldn't be assumed that mutexes work otherwise, what is the point of testing them ? |
Add descriptions, fix small issues and timings.
|
LGTM @pan- What do you think? |
| if (changing_counter == true) { | ||
| result = false; | ||
| mutex_defect = true; | ||
| } | ||
| changing_counter = true; | ||
|
|
||
| change_counter++; | ||
| core_util_critical_section_exit(); |
There was a problem hiding this comment.
Now, I'm thinking about, change_counter Is the variable under test. It is maybe not the best to protect it with a critical section like other flags.
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Add descriptions, fix small issues and timings
Status
READY