Parse and use custom targets in exporters #4725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The actual |
|
@screamerbg FYI |
|
@theotherjimmy yes 👍 |
|
@theotherjimmy Who should review this change? |
|
Good question, @0xc0170. I don't know. Maybe @sarahmarshy? |
|
/morph export-build |
sarahmarshy
approved these changes
Jul 10, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 83 All exports and builds passed! |
|
@adbridge LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4709
Also changes the API of the exporters to be more flexible WRT changes in
TARGET_MAP. The old API would pre-compute a supported list at import time.
This new API includes a class method for computing support for one target
or all targets. This might improve performace for single exports, as only
the current combination of support is checked instead of the whole matrix.