-
Notifications
You must be signed in to change notification settings - Fork 3k
[ONME-3089] - Adjust lowpan ND interface connect timeout #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
retest uvisor |
mesh-minimal automated test's were executed with this mbed-os version. |
@mikaleppanen and @kjbracey-arm could you please review my change |
// wait connection for ever: | ||
// -routers will create new network and get local connectivity | ||
// -end devices will get connectivity once attached to existing network | ||
// -devices without network settings gets connectivity once commissioned and attached to network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are applicable to thread. 6lowpan would need different wording about routers, host etc. But I think that there is no need to specify here what happens i.e. leaving only comment "wait connection for ever" is enough.
retest uvisor |
Device needs to wait for connectivity: -routers will create new network and get local connectivity -end device will get connectivity once attached to existing network -devices without network settings gets connectivity once commissioned and attached to network Signed-off-by: Kari <[email protected]>
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Thread already changed interface connection timeout to wait forever,
so the lowpan ND needs to change too.
Device needs to wait for connectivity:
-routers will create new network and get local connectivity
-end device will get connectivity once attached to existing network
-devices without network settings gets connectivity once
commissioned and attached to network