Skip to content

[ONME-3089] - Adjust lowpan ND interface connect timeout #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2017
Merged

[ONME-3089] - Adjust lowpan ND interface connect timeout #4592

merged 1 commit into from
Jul 13, 2017

Conversation

KariHaapalehto
Copy link
Contributor

Thread already changed interface connection timeout to wait forever,
so the lowpan ND needs to change too.

Device needs to wait for connectivity:
-routers will create new network and get local connectivity
-end device will get connectivity once attached to existing network
-devices without network settings gets connectivity once
commissioned and attached to network

@bridadan
Copy link
Contributor

retest uvisor

@KariHaapalehto
Copy link
Contributor Author

mesh-minimal automated test's were executed with this mbed-os version.
All test were passed and the test results can be found from:
https://jenkins-internal.mbed.com/view/Morpheus_CI/job/mbed-os-example-mesh-minimal-6lowpan-hw-test/300/testReport/

@KariHaapalehto
Copy link
Contributor Author

@mikaleppanen and @kjbracey-arm could you please review my change

// wait connection for ever:
// -routers will create new network and get local connectivity
// -end devices will get connectivity once attached to existing network
// -devices without network settings gets connectivity once commissioned and attached to network

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are applicable to thread. 6lowpan would need different wording about routers, host etc. But I think that there is no need to specify here what happens i.e. leaving only comment "wait connection for ever" is enough.

@theotherjimmy
Copy link
Contributor

retest uvisor

Device needs to wait for connectivity:
-routers will create new network and get local connectivity
-end device will get connectivity once attached to existing network
-devices without network settings gets connectivity once
 commissioned and attached to network

Signed-off-by: Kari <[email protected]>
@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 696

Test failed!

@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 766

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants