Increase background stack size to fix overflow #4563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the background stack size to 512 bytes to fix stack overflows on the NRF52 and so it is the same size as it was before the switch to RTX5.
0xc0170
approved these changes
Jun 15, 2017
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
pan-
approved these changes
Jun 15, 2017
|
@c1728p9 Looks like this caused some examples to no longer fit into 16KB. |
The stack required for the idle thread is highly dependent on the target because it will call the sleep function which is target specific. While 256 bytes of stack is enough for most targets, others like the NRF52840 might require more. With this change, target maintainers can specify the idle thread stack size in their mbed_rtx.h file.
A stack size of 256 bytes is not enough on the NRF52840, this patch changes it to a size of 512 bytes.
|
@c1728p9 I've extended your PR by allowing targets to override the default value of the idle thread stack size. It makes a lot of sense to let it be defined at targets level because the amount of stack needed is directly correlated to the sleep function which is target specific. @0xc0170 Please review. |
0xc0170
approved these changes
Jun 16, 2017
|
@pan- should this be a config option? |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the background stack size to 512 bytes to fix stack overflows on the NRF52 and so it is the same size as it was before the switch to RTX5.