Resolve Warnings for mbed-os-examples #4548
Conversation
| @@ -28,8 +28,11 @@ void hal_sleep(void) | |||
| void hal_deepsleep(void) | |||
| { | |||
| #if (defined(FSL_FEATURE_SOC_MCG_COUNT) && FSL_FEATURE_SOC_MCG_COUNT) | |||
| #if defined(kMCG_ModePEE) | |||
There was a problem hiding this comment.
If this is one commit (might be fine for this type of change) - please include as much details as you can . I would recommend to include what warnings are fixed here. For instance, what this ModePEE does ? how is it related to CLOCK_GetMode() ?
| @@ -402,7 +402,7 @@ static void (*callFlashCommonBitOperation)(FTFx_REG32_ACCESS_TYPE base, | |||
| * @endcode | |||
| * Note2: The binary code is generated by IAR 7.70.1 | |||
| */ | |||
| const static uint16_t s_flashRunCommandFunctionCode[] = { | |||
There was a problem hiding this comment.
cc @mmahadevan108 please review this as it shall go upstream to fix warnings in drivers code
| #else | ||
| #if (defined(__CC_ARM)) | ||
| #pragma pop | ||
| #endif // (defined(__CC_ARM)) |
There was a problem hiding this comment.
consistency, they use /* */ for comments, and I assume this is for readability, but not used in this file as it is on this line (no comments at endif, only for features).
|
@0xc0170 How would you like the commit message changed? |
|
Can you list the warning in the commit message this fixes. |
…n resulted in a change of sign
…nning of declaration [-Wold-style-declaration]
…ma push : Pragma push for CC_ARM option is inside GNUC define, same hierarchy to be followed while pop
…o determine kMCG_ModePEE in case of PEE to switch back manually as default after wakeup MCG is in PBE mode. this is required only when PEE mode is required
…etween signed and unsigned integer expressions
… but argument 3 has type 'u32_t[-Wformat=]
|
Thanks @deepikabhavnani . |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
Description
Resolving build warnings for mbed-os examples
Status
IN DEVELOPMENT
Todos