avoid 03/05 intel-hex records for nordic devices #4276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Intelhex::write_hex_file instead of IntelHex::tofile
theotherjimmy
approved these changes
May 5, 2017
|
I'm curious: why don't you need the start address? |
|
For NRF5 any of mbed-os app has a SoftDevice (SD) incorporated. SoftDevice is a BlackBox - the SoC run it thanks to the its reset handler (as for any else cortex-m device) and after some magic Softdevice call the user application. So for Nordic devices we expected run using reset - practical we even don't know where is the reset handler or the main of the SoftDevice. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
? @sg- did something go awry? |
|
not sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Intelhex::write_hex_file instead of IntelHex::tofile do the work.
Mentioned records types has no sense for nordic devices.
Sucha a record comes from *.hex file from the mbed-os sources build.
This PR solves #4237