-
Notifications
You must be signed in to change notification settings - Fork 3k
Add support for Unmanaged Bootloader #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC and Review |
/morph test |
cbe8546
to
ab6450d
Compare
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
/morph test |
retest uvisor |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
This could be useful. Thx. |
ab6450d
to
2b757ec
Compare
@theotherjimmy Still underdevelopment (was updated but no mention here why and what has changed) ? |
@0xc0170 I changed the names of things after some productive bikeshedding and talking to a partner engineer offline. I should have informed the PR of what happened. Let's re-run testing, and then we should be good. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@marcuschangarm Could you review? |
I'm not familiar enough with the mbed tools system to offer qualified advice. |
@marcuschangarm Could you comment on the usability then? |
@theotherjimmy please rebase |
Just gave it a spin and it works great! Two things:
|
as
I'll work on that. |
2b757ec
to
fd26d5b
Compare
7952a30
to
bbde379
Compare
@marcuschangarm I just made all builds link steps depend on their respective mbed_app.json files. That should fix the dependency issue with both this style bootloader and other config issues. |
Hmm...I don't get a rebuild when I modify the mbed_app.json. I'm on mbed-cli 1.1.1 and mbed-os bbde379 from your branch. |
@marcuschangarm the dependency only affects the link step. Would you like all c and c++ files depend to the app config? |
@theotherjimmy it seems safest since you are exposing variables like |
I'll get that today |
@marcuschangarm That should do it. |
@theotherjimmy Works great! Thank you very much! 🎉 |
Your welcome @marcuschangarm Looks like I broke some unit tests. Now to update them... |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Looks like it is ready to ship! 🎉 |
Description
This allows a user to build a completely customized bootloader configuration.
The new configuration options are:
target.mbed_app_start
: The start address of the applicationtarget.mbed_app_size
: The size of the applicationWhen elided, the defaults are:
target.mbed_app_start
defaults to the start of ROMtarget.mbed_app_size
defaults to the remaining ROM from the start of the applicationChecks are performed to verify that:
target.mbed_app_start
is a location in ROMtarget.mbed_app_size
+target.mbed_app_start
is also a location in ROM or 1 byte past the end of ROMTests
mbed_app_start
andmbed_app_size
change the apps startand size, respectively
mbed_app_*
are mutually exclusive