Skip to content

DISCO_L053C8: Add support of USB Device #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2017
Merged

DISCO_L053C8: Add support of USB Device #4015

merged 4 commits into from
Apr 6, 2017

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Mar 24, 2017

Description

Add the support of USB Device on the DISCO_L053C8 platform.

USB_1 (HID) and USB_4 (Serial) tests are OK.

Fix Issue #4010

Status

READY

Migrations

NO

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1766

All builds and test passed!

0xc0170
0xc0170 reviewed Mar 29, 2017
View reviewed changes
targets/TARGET_STM/TARGET_STM32L0/TARGET_DISCO_L053C8/USBHAL_STM32L053C8.h Outdated

USBHAL * USBHAL::instance;

USBHAL::USBHAL(void) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the cody style for opening function body in this file

@bcostm bcostm force-pushed the dev_disco-l053c8_usb branch from f5ae7b2 to 3302a37 Compare March 30, 2017 12:58
@bcostm
Copy link
Contributor Author

bcostm commented Mar 30, 2017

Typo corrections added.

@bcostm
Copy link
Contributor Author

bcostm commented Apr 4, 2017

Any news when this will be merged ? A customer is requesting it.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2017

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Apr 4, 2017

[Build 1332]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2017

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2017

[Build 1332]

@bridadan It reports green, but I cant go to the tests there to review, internal error?

@bridadan
Copy link
Contributor

bridadan commented Apr 4, 2017 •
edited
Loading

@0xc0170 The failure was the mbed 2 CI (The check called continuous-integration/mbedci). I have been tracking this kind of failure for a while now and I think I may have just tackled the root cause of it! I'll restart the CI.

Hint: the root cause was very silly, as are most issues 😄

@bridadan
Copy link
Contributor

bridadan commented Apr 4, 2017

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Apr 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1826

All builds and test passed!

@mbed-bot
Copy link

mbed-bot commented Apr 4, 2017

[Build 1333]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg- sg- merged commit d5058aa into ARMmbed:master Apr 6, 2017
@bcostm bcostm deleted the dev_disco-l053c8_usb branch April 7, 2017 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.5.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcostm @0xc0170 @mbed-bot @bridadan @sg-