Use the C Pre-Processor on GCC Linker scripts #3706
Conversation
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=ALL |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
[Build 1250] |
|
@c1728p9 looks like some build failures. |
|
I just did a spot check on some of those failures, and I could not reproduce them. |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
In order to reproduce the CI failures you may to enable the heap and stat stats: |
|
Yes, I ran exactly that command line, copied from the CI logs |
tools/test_api.py
Outdated
| @@ -2201,12 +2201,12 @@ def build_tests(tests, base_source_paths, build_path, target, toolchain_name, | |||
| report[target_name][toolchain_name][test_key] = report_entry[test_key] | |||
|
|
|||
| # Set the overall result to a failure if a build failure occurred | |||
| if not worker_result['result'] and not isinstance(worker_result['reason'], NotSupportedException): | |||
| if 'reason' in worker_result and not isinstance(worker_result['reason'], NotSupportedException): | |||
There was a problem hiding this comment.
For this line I think you still need to have the not worker_result['result'] clause as well. So:
if 'reason' in worker_result and not worker_result['result'] and not isinstance(worker_result['reason'], NotSupportedException):
tools/test_api.py
Outdated
| result = False | ||
| break | ||
|
|
||
| # Adding binary path to test build result | ||
| if worker_result['result'] and 'bin_file' in worker_result: | ||
| if 'result' in worker_result and 'bin_file' in worker_result: |
There was a problem hiding this comment.
Similar thing here as above:
if 'result' in worker_result and worker_results['result'] and 'bin_file' in worker_result:
theotherjimmy
force-pushed
the
pre_process
branch
from
4072f00 to
c594a88
Compare
c1728p9
changed the title
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
/morph export-bulid |
This allows us to define parts of the linker script outside of the linker script itself. In particular, we are interested in restricting ROM to a subsection.
For toolchains that do not implicitly run the C pre-processor on their linker scripts the toolchain is expected to define a `preproc` attribute. The Makefiles then pick up on this attribute and add another rule for pre-processing the linker script automatically.
theotherjimmy
force-pushed
the
pre_process
branch
from
37b5173 to
3155e71
Compare
|
Whoops. I goofed. Should be working again |
|
/morph test |
|
Only one bot kick per comment it seems |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 115 All exports and builds passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
This allows us to define parts of the linker script outside of the linker script itself. In particular, we are interested in restricting ROM to a subsection.