Modify update command to directly edit the mbed-os.lib files for each example #3528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example specified in the supplied .json file, in a user specified fork.
A pull request is then made from each fork to the ARMmbed master repo.
New usage:
python update.py <args>
Where <args> are:
[-c <file.json>] optional argument for example list, default
example.json
-U <github user with forked repos>
-T <github authorisation token>
tag
|
@bridadan please review. |
| cmd = ['git', 'push', '-f', 'origin'] | ||
| return_code = run_cmd(cmd) | ||
| if not return_code: | ||
| ret = True |
There was a problem hiding this comment.
Wow. Is this really the best way to do this? Maybe:
for cmd in [['git', 'remote', 'add', 'armmbed', arm_example],
['git', 'fetch', 'armmbed'],
['git', 'reset', '--hard', 'armmbed/master'],
['git', 'push', '-f', 'origin']]:
if run_cmd(cmd):
print("preparation of the fork failed!")
return False
return TrueThere was a problem hiding this comment.
yeah that looks better :)
bridadan
suggested changes
Jan 5, 2017
| print("Ignoring and moving on to the next example") | ||
| os.chdir(cwd) | ||
| if os.path.isfile("mbed-os.lib"): | ||
| os.system("mv mbed-os.lib mbed-os.lib_bak") |
There was a problem hiding this comment.
mv is not a valid command on Windows, can you use os.rename instead please?
| "This usually inidicates that no update was made. Still " + \ | ||
| "attempting to create a tag.") | ||
| if not return_code: | ||
| body = "Please test/merge this PR and then tag Master with " + tag |
There was a problem hiding this comment.
Until all the example owners have automatic testing of their examples for each PR, then they need the prompt!
In prepare_fork(), change nested IF to neat command loop.
|
@bridadan @theotherjimmy review comments added and retested locally. Please re-review. |
theotherjimmy
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as specified in the supplied .json file, in a user specified fork.
A pull request is then made from each fork to the ARMmbed master repo.
New usage:
python update.py
Where are:
[-c <file.json>] optional argument for example list, default
example.json
-U
-T
tag