Limiting the thread stack for parallel threads test #3484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the RTOS threads test was conditionally change the thread stack size for all test cases based on the target. Now, it uses the default stack size for all targets when threads are created serially, and uses a 512 byte stack for the threads that are created in parallel.
|
/morph test |
|
+1 for technical terminology |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
c1728p9
approved these changes
Dec 21, 2016
pan-
approved these changes
Dec 21, 2016
|
I fixed it in features_cmsis5 branch, but using default stack size (4k by default but can be change per platform). |
|
@VeliMattiLahtela Please restart CI ? looks like it;s not progressing. |
0xc0170
approved these changes
Dec 21, 2016
|
|
Needs to be green :-) I restarted the job |
geky
approved these changes
Dec 21, 2016
0xc0170
added
ready for merge
release-version: 5.3.2
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the RTOS threads test would conditionally change the thread stack size for all test cases based on the target. Now, it uses the default stack size for all targets when threads are created serially, and uses a 512 byte stack for the threads that are created in parallel.
Also, this should remove the last failing test case on the ARCH_PRO platform :)
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
Notes to Reviewers
Requesting reviews by @c1728p9 and @geky since they are familiar with all things RTOS and stack-sizey (yes that's a technical term)
Also requesting a review by @pan- as this may affect some of the BLE platforms/constrained mbeds.