lwiperf: fix double-free of pcb on error

.github/workflows/basic_checks.yml

@@ -17,9 +17,10 @@ jobs:
 
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
+
 
       - 
         name: install dependencies
@@ -32,7 +33,7 @@ jobs:
         run: |
           set -x
           mkdir -p SCANCODE
-
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} \
             | ( grep '.\(c\|cpp\|h\|hpp\|py\)$' || true )
           echo $?
@@ -60,13 +61,14 @@ jobs:
 
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
       - 
         name: include check
         run: |
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           # checks mbed.h is not included in MbedOS files except in tests
           ! git grep '^#include\s["'"']mbed.h['"'"]$' -- '*.c' '*.h' '*.cpp' '*.hpp' \
               ':!*platform_mbed.h' ':!*TESTS/*' ':!TEST_APPS/' ':!UNITTESTS/' \
@@ -81,13 +83,14 @@ jobs:
     steps:
 
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
       - 
         name: UTF-8 Check
         run: |
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           # Make sure we're not introducing any text which is not UTF-8 encoded
           git diff origin/${GITHUB_BASE_REF} -U0 | ( grep -a '^+' || true ) | ( ! grep -axv '.*' )
 
@@ -96,6 +99,7 @@ jobs:
         name: astyle checks
         run: |
           set -x
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} \
             | ( grep '.*\.\(c\|cpp\|h\|hpp\)$' || true ) \
             | ( grep -v -f .codecheckignore || true ) \
@@ -111,7 +115,7 @@ jobs:
     steps:
 
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -155,7 +159,7 @@ jobs:
     steps:
       -
         name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
 
       - uses: actions/setup-python@v2
@@ -184,14 +188,15 @@ jobs:
     steps:
       -
         name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
       -
         name: validate pins
         run: |
           set -x
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} \
             | ( grep '.*[\\|\/]PinNames.h$' || true ) \
             | while read file; do python ./hal/tests/pinvalidate/pinvalidate.py -vvvfp "${file}"; done
@@ -210,7 +215,7 @@ jobs:
     steps:
       -
         name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       -
         name: cmake build
@@ -237,14 +242,15 @@ jobs:
       steps:
         -
           name: Checkout repo
-          uses: actions/checkout@v2
+          uses: actions/checkout@v3
           with:
             fetch-depth: 0
 
         -
           name: frozen tool check
           run: |
               set -x
+              git config --global --add safe.directory "$GITHUB_WORKSPACE"
               git diff --name-only origin/${GITHUB_BASE_REF} \
                       | egrep \
                         -e "^tools/build_api*" \

.github/workflows/docker_management.branch.yml

@@ -35,7 +35,7 @@ jobs:
 
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -117,7 +117,7 @@ jobs:
 
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       -
         name: Build docker containers
@@ -164,7 +164,7 @@ jobs:
 
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - 
         name: Find DEV DOCKER DIGEST
@@ -178,7 +178,7 @@ jobs:
       # development branch of blinky
       - 
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: ARMmbed/mbed-os-example-blinky
           path: mbed-os-example-blinky

.github/workflows/docker_management.prune.yml

@@ -13,7 +13,7 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - 
         name: Delete old temporary images
@@ -22,4 +22,4 @@ jobs:
           # deletion if only one image exists or if DOCKER_MANAGEMENT_TOKEN is not 
           # setup. This shouldn't create any alarm as temporary image deletion is 
           # not a critical activity.
-          python ./.github/workflows/ci_scripts/ghcr_utils.py -u ${{ github.repository_owner }} -p ${{ secrets.DOCKER_MANAGEMENT_TOKEN }} delete-old-images -r mbed-os-env-tmp || true
+          python ./.github/workflows/ci_scripts/ghcr_utils.py -u ${{ github.repository_owner }} -p ${{ secrets.DOCKER_MANAGEMENT_TOKEN }} delete-old-images -r mbed-os-env-tmp || true

.github/workflows/docker_management.release.yml

@@ -24,7 +24,7 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -134,7 +134,7 @@ jobs:
 
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: refs/tags/${{ steps.build_info.outputs.MBED_OS_VERSION }}
 
@@ -198,7 +198,7 @@ jobs:
       # development branch of blinky
       - 
         name: Checkout example blinky
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: ARMmbed/mbed-os-example-blinky
           path: mbed-os-example-blinky
@@ -224,7 +224,7 @@ jobs:
 
       - 
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: refs/tags/${{ steps.build_info.outputs.MBED_OS_VERSION }}
           path: mbed-os-example-blinky/mbed-os

.github/workflows/docker_management.test-PR.yml

@@ -34,7 +34,7 @@ jobs:
       # for PR tests, development branch of blinky is used
       - 
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: ARMmbed/mbed-os-example-blinky
           path: mbed-os-example-blinky
@@ -49,7 +49,7 @@ jobs:
 
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           path: mbed-os-example-blinky/mbed-os
 

.github/workflows/greentea_cmake.yml

@@ -8,7 +8,7 @@ jobs:
     container: ghcr.io/armmbed/mbed-os-env:master-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Install the latest mbed-tools
         run: |

.github/workflows/main.yml

@@ -8,15 +8,15 @@ jobs:
 
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Install Python environment
         uses: actions/setup-python@v2
         with:
           python-version: 3.8
 
       - name: Checkout mbed-os-scripts repo (This repo is currently private)
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: ARMmbed/mbed-os-ci-scripts
           token: ${{ secrets.ISSUE_TRIAGING_PERMS }}

.github/workflows/run_conditional_ble_feature_compilation.yml

@@ -11,7 +11,7 @@ jobs:
     container: mbedos/mbed-os-env:latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           path: mbed-os
 

.github/workflows/test_building_multiple_executables.yml

@@ -8,7 +8,7 @@ jobs:
     container: ghcr.io/armmbed/mbed-os-env:master-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Build the multiple_executables example
         run: |

connectivity/FEATURE_BLE/README.md

@@ -8,3 +8,19 @@ This is the Github repository for the `BLE_API`. Please see the [Mbed OS Example
 * [Mbed OS example BLE GitHub repo](https://github.com/ARMmbed/mbed-os-example-ble) for all Mbed OS BLE examples.
 * [Mbed OS BLE introduction](https://os.mbed.com/docs/latest/apis/ble.html) for an introduction to Mbed BLE.
 * [Mbed OS BLE API page](https://os.mbed.com/docs/latest/apis/bluetooth.html) for the Mbed BLE API documentation.
+
+## Privacy notice
+
+The Cordio Bluetooth stack only stores one single signing key. This key is then 
+shared across all bonded devices. If a malicious device bonds with the Mbed OS 
+application it then gains knowledge of the shared signing key of the Mbed OS device. 
+The malicious device can then track the Mbed OS device whenever a signing write 
+is issued from it. 
+
+To overcome this privacy issue do not issue signed writes from the Mbed OS device.
+A signed write occurs when the member function `write` of `GattClient` is called 
+with its `cmd` argument set to `GATT_OP_SIGNED_WRITE_CMD`.
+
+Instead of using signed writes, enable encryption on the connection. This is achieved
+ by calling the function `setLinkEncryption` of the `SecurityManager`. Set the encryption 
+to at least `ENCRYPTED`. 

connectivity/cellular/include/cellular/framework/AT/AT_CellularDevice.h

@@ -67,7 +67,7 @@ class AT_CellularDevice : public CellularDevice {
     };
 
 public:
-    AT_CellularDevice(FileHandle *fh);
+    AT_CellularDevice(FileHandle *fh, char *delim = "\r");
     virtual ~AT_CellularDevice();
 
     virtual nsapi_error_t clear();

connectivity/cellular/source/framework/AT/AT_CellularDevice.cpp

@@ -39,9 +39,9 @@ using namespace std::chrono_literals;
 #define DEFAULT_AT_TIMEOUT 1s // at default timeout
 const int MAX_SIM_RESPONSE_LENGTH = 16;
 
-AT_CellularDevice::AT_CellularDevice(FileHandle *fh) :
+AT_CellularDevice::AT_CellularDevice(FileHandle *fh, char *delim):
     CellularDevice(),
-    _at(fh, _queue, DEFAULT_AT_TIMEOUT, "\r"),
+    _at(fh, _queue, DEFAULT_AT_TIMEOUT, delim),
 #if MBED_CONF_CELLULAR_USE_SMS
     _sms(0),
 #endif // MBED_CONF_CELLULAR_USE_SMS

connectivity/cellular/tests/UNITTESTS/doubles/AT_CellularDevice_stub.cpp

@@ -33,9 +33,9 @@ bool AT_CellularDevice_stub::pin_needed = false;
 bool AT_CellularDevice_stub::supported_bool = false;
 int AT_CellularDevice_stub::max_sock_value = 1;
 
-AT_CellularDevice::AT_CellularDevice(FileHandle *fh) :
+AT_CellularDevice::AT_CellularDevice(FileHandle *fh, char *delim) :
     CellularDevice(),
-    _at(fh, _queue, get_property(AT_CellularDevice::PROPERTY_AT_SEND_DELAY), "\r"),
+    _at(fh, _queue, get_property(AT_CellularDevice::PROPERTY_AT_SEND_DELAY), delim),
 #if MBED_CONF_CELLULAR_USE_SMS
     _sms(0),
 #endif // MBED_CONF_CELLULAR_USE_SMS

connectivity/drivers/emac/TARGET_ARM_SSG/COMPONENT_SMSC9220/smsc9220_emac.cpp

@@ -89,14 +89,13 @@ emac_mem_buf_t *SMSC9220_EMAC::low_level_input()
         message_length -= CRC_LENGTH_BYTES;
     }
 
-    p = _memory_manager->alloc_heap(SMSC9220_ETH_MAX_FRAME_SIZE,
+    p = _memory_manager->alloc_heap(message_length,
                                     SMSC9220_BUFF_ALIGNMENT);
 
     if (p != NULL) {
         _RXLockMutex.lock();
-        received_bytes = smsc9220_receive_by_chunks(dev,
-                                  (char*)_memory_manager->get_ptr(p),
-                                  _memory_manager->get_len(p));
+        received_bytes = smsc9220_receive_packet(dev,
+                                  _memory_manager->get_ptr(p));
         if(received_bytes == 0){
             _memory_manager->free(p);
             p = nullptr;
@@ -148,7 +147,6 @@ bool SMSC9220_EMAC::link_out(emac_mem_buf_t *buf)
     if(buf == NULL) {
         return false;
     } else {
-        uint32_t buffer_chain_length = 0;
         enum smsc9220_error_t error = SMSC9220_ERROR_NONE;
         /* If buffer is chained or not aligned then
          * make a contiguous aligned copy of it */
@@ -170,16 +168,12 @@ bool SMSC9220_EMAC::link_out(emac_mem_buf_t *buf)
             buf = copy_buf;
         }
 
-        buffer_chain_length = _memory_manager->get_total_len(buf);
-
         _TXLockMutex.lock();
-        error = smsc9220_send_by_chunks(dev,
-                                      buffer_chain_length,
-                                      true,
-                                      (const char*)_memory_manager->get_ptr(buf),
+        error = smsc9220_send_packet(dev,
+                                      _memory_manager->get_ptr(buf),
                                       _memory_manager->get_len(buf));
         _memory_manager->free(buf);
-        _TXLockMutex.unlock();
+        _TXLockMutex.unlock();        
         return (error == SMSC9220_ERROR_NONE);
     }
 }
@@ -211,7 +205,7 @@ bool SMSC9220_EMAC::power_up()
                                    this));
 
     /* Initialize the hardware */
-    enum smsc9220_error_t init_successful = smsc9220_init(dev, &ThisThread::sleep_for);
+    enum smsc9220_error_t init_successful = smsc9220_init(dev, &thread_sleep_for);
     if (init_successful != SMSC9220_ERROR_NONE) {
         return false;
     }
@@ -237,7 +231,7 @@ bool SMSC9220_EMAC::power_up()
                                              &SMSC9220_EMAC::link_status_task));
 
     /* Allow the Link Status task to detect the initial link state */
-    ThisThread::sleep_for(10);
+    ThisThread::sleep_for(10ms);
     _link_status_task_handle = mbed::mbed_event_queue()->call_every(
                               LINK_STATUS_TASK_PERIOD_MS,
                               mbed::callback(this,

connectivity/drivers/emac/TARGET_ARM_SSG/COMPONENT_SMSC9220/smsc9220_emac_config.h

@@ -36,7 +36,7 @@
 #define FLAG_RX                              1U
 #define LINK_STATUS_THREAD_PRIORITY          (osPriorityNormal)
 #define LINK_STATUS_THREAD_STACKSIZE         512U
-#define LINK_STATUS_TASK_PERIOD_MS           200U
+#define LINK_STATUS_TASK_PERIOD_MS           200ms
 #define PHY_STATE_LINK_DOWN                  false
 #define PHY_STATE_LINK_UP                    true
 #define CRC_LENGTH_BYTES                     4U