Skip to content

CMake: Fix Cypress MCU_PSOC6_M4 build #14232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Ensure the RTOS source file are included
if the full profile is used. The macro CY_RTOS_AWARE
is added whenever the full profile is used

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Ensure the RTOS source file are included
if the full profile is used. The macro CY_RTOS_AWARE
is added whenever the full profile is used
@hugueskamba hugueskamba requested review from 0xc0170 and a team February 3, 2021 14:20
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First impression this requires rtos by default - how baremetalw would work but this is specific implementation for rtos that is enabled only by a flag

@mergify mergify bot added the needs: CI label Feb 3, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_cmake-example-test

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Feb 5, 2021
@0xc0170 0xc0170 merged commit bff8b8e into ARMmbed:master Feb 5, 2021
@mergify mergify bot removed the ready for merge label Feb 5, 2021
@hugueskamba hugueskamba deleted the hk_fix_cypress_mcu_psoc6_m4 branch February 5, 2021 12:19
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants