Skip to content

BLE: fix scanning/advertising when extended features are available but disabled on host #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

Between resets the stack can only either use extended commands or legacy commands exclusively.

NRF52840 initialises extended commands in the controller which means the controller will reject standard scanning when it is used when the feature is disabled through the BLE feature config at the host level. This adds missing guards around commands that generate extended HCI commands.

Impact of changes

Migration actions required

Documentation

none


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 4, 2021
@ciarmcom ciarmcom requested review from pan- and a team January 4, 2021 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 4, 2021

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@paul-szczepanek-arm
Copy link
Member Author

Fixes: #14053

@AGlass0fMilk
Copy link
Member

Nice work! 💯

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding. Thanks @paul-szczepanek-arm .

@mergify mergify bot added needs: CI and removed needs: review labels Jan 4, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 5, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants