Skip to content

CMake: Add support for all ARM FM Mbed targets #13964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Add CMakeLists.txt files so all ARM's FM Mbed targets can be built with CMake

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Add CMakeLists.txt files so all ARM's FM Mbed targets can be built with CMake
@MarceloSalazar
Copy link

LGTM.
Maybe @jamesbeyond would like to comment as this FM target was introduced by him?

0xc0170
0xc0170 previously approved these changes Nov 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

CI started

@mergify mergify bot added the needs: CI label Nov 25, 2020
@mergify mergify bot dismissed 0xc0170’s stale review November 25, 2020 16:00

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@hugueskamba hugueskamba changed the title CMake: Add support for all ARM's FM Mbed targets CMake: Add support for all ARM FM Mbed targets Nov 26, 2020
@hugueskamba hugueskamba force-pushed the hk_cmake_arm_fm_support branch from e4abeb7 to def23e1 Compare November 26, 2020 11:31
@hugueskamba hugueskamba requested a review from 0xc0170 November 26, 2020 11:33
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2020

CI restarted

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Nov 26, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit b20278a into ARMmbed:master Nov 26, 2020
@mergify mergify bot removed the ready for merge label Nov 26, 2020
@hugueskamba hugueskamba deleted the hk_cmake_arm_fm_support branch November 26, 2020 16:02
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants