Skip to content

Update PSoC64 TFM release package. #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2020
Merged

Update PSoC64 TFM release package. #13418

merged 1 commit into from
Aug 14, 2020

Conversation

CharleyChu
Copy link

Summary of changes 

- Fix key derivation issue
- Replace IPC semaphore spin-lock with IPC lock

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 12, 2020
@ciarmcom ciarmcom requested review from maclobdell and a team August 12, 2020 05:00
@ciarmcom
Copy link
Member

@CharleyChu, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-core @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed request for a team August 12, 2020 07:42
0xc0170
0xc0170 requested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, two merge commits are not needed here

0xc0170
0xc0170 previously approved these changes Aug 12, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Aug 12, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2020

CI started

@mergify mergify bot dismissed 0xc0170’s stale review August 12, 2020 19:45

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Aug 12, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ❌

@RaymondNgun
Copy link

RaymondNgun commented Aug 12, 2020 •
edited
Loading

@0xc0170, any comments on CI failure here? I would think its completely unrelated to the patch set. By the way, this is high priority code 6.2.1 code freeze. Please see if you can push this along for the code freeze. Thanks!

psoc64: Update TF-M release image
4749e17 
- Fix key derivation issue
- Update PSoC64 BSP
- Replace IPC semaphore spin-lock with IPC lock

Signed-off-by: Charley Chu <[email protected]>
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

@0xc0170, any comments on CI failure here? I would think its completely unrelated to the patch set. By the way, this is high priority code 6.2.1 code freeze. Please see if you can push this along for the code freeze. Thanks!

Thanks for the information, we will make sure it is in today

@MarceloSalazar MarceloSalazar mentioned this pull request Aug 13, 2020
Closed
@mbed-ci
Copy link

mbed-ci commented Aug 13, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 mentioned this pull request Aug 13, 2020
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

@paul-szczepanek-arm Can you rereview?

@mergify mergify bot added needs: work and removed needs: CI labels Aug 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2020

@donatieng All answered?

@donatieng
Copy link
Contributor

I'm checking with @ARMmbed/mbed-os-security, I'll ping back here ASAP.

donatieng
donatieng approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@donatieng donatieng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @Patater, all good regarding the 1.0 version update 👍

@0xc0170 0xc0170 merged commit 3ff5a3b into ARMmbed:master Aug 14, 2020
@mergify mergify bot removed the ready for merge label Aug 14, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaymondNgun RaymondNgun RaymondNgun left review comments

@donatieng donatieng donatieng approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@maclobdell maclobdell Awaiting requested review from maclobdell

@paul-szczepanek-arm paul-szczepanek-arm Awaiting requested review from paul-szczepanek-arm

Assignees
No one assigned
Labels
devices: cypress release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@CharleyChu @ciarmcom @0xc0170 @mbed-ci @RaymondNgun @donatieng @paul-szczepanek-arm @mbedmain