Adding Samsung Bioprocessor S1SBP6A target #13392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@heuisam, thank you for your changes. |
0xc0170
previously requested changes
Aug 10, 2020
| extern const PinMap PinMap_SPI_SSEL[]; | ||
| #endif | ||
|
|
||
| #endif |
There was a problem hiding this comment.
please add a newline at the end of file (other files in this pull request have it)
There was a problem hiding this comment.
Thank you for your comment. I'll fix it.
There was a problem hiding this comment.
If you fix, please comment in the pull request - what has been updated. I can see it was forced pushed but github still shows here "no new line"
There was a problem hiding this comment.
I'm sorry it was missed.
I'll update it and add comment for changes.
targets/targets.json
Outdated
| "S1SBP6A": { | ||
| "inherits": ["Target"], | ||
| "core": "Cortex-M4F", | ||
| "supported_toolchains": ["GCC_ARM", "ARMC6"], |
There was a problem hiding this comment.
can these be on new lines same as device_has ?
Also line 6571
There was a problem hiding this comment.
Thank you. I'll change it.
The TARGET_Samsung had security_subsystem and SIDK_S5JS100. If I add another target that does not use security_subsystem, I get a build error. This commit moves security_subsyste to TARGET_SIDK_S5JS100. Signed-off-by: Heuisam Kwag <[email protected]>
0xc0170
previously approved these changes
Aug 11, 2020
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Signed-off-by: Heuisam Kwag <[email protected]>
Change List
|
0xc0170
approved these changes
Aug 12, 2020
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adding a new target of HW development kit using Samsung Bioprocessor S1SBP6A to mMbed-OS.
S1SBP6A is a low-power bio-porcessor targeting multiple bio-sensor data acquisition and processing for healthcare and other applications.
Moving security_subsystem into TARGET_SIDK_S5JS100 to fix build error when S1SBP6A target is added.
Main author : Heuisam Kwag [email protected]
Documentation
Pull request type
Test results
arm
gcc
Reviewers