Fix Mbed TLS + TF-M integration issues #13337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using TF-M, be sure to specify the length of the key. Fixes: 0961f31 ("Make PSA util compatible with Mbed Crypto 3.0.1")
ciarmcom
added
the
release-type: patch
|
@Patater, thank you for your changes. |
moshe-shahar
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
@Patater,
I tested it locally and it works as expected.
Thank you!
0xc0170
previously approved these changes
Jul 23, 2020
When using TF-M, use the PSA_KEY_TYPE_ECC_KEY_PAIR() macro from mbedtls_psa_parse_tls_ecc_group(), since that function is supposed to return a psa_key_type_t. This helps to avoid any misencodings when the return value from mbedtls_psa_parse_tls_ecc_group() is used directly as a psa_key_type_t without additional encoding. Fixes: 0961f31 ("Make PSA util compatible with Mbed Crypto 3.0.1")
|
@moshe-shahar I've modified the code a bit based on review feedback. Could you ensure it still works as intended for you? |
urutva
approved these changes
Jul 23, 2020
0xc0170
approved these changes
Jul 23, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
mbedmain
added
release-version: 6.2.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ensure PSA key types and key lengths are handled properly when using Mbed TLS with TF-M.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers