-
Notifications
You must be signed in to change notification settings - Fork 3k
Events directory restructuring #13333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
6687caa
to
cd19531
Compare
Rebased. |
cd19531
to
52e78ac
Compare
Travis events job is still failing, please review |
@gpsimenos, thank you for your changes. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
712eed4
to
4824dad
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profiling tests should be restored (so we might all well restore the two test files)
4824dad
to
3070ebc
Compare
Rebased and restored profiling tests. Didn't restore unit tests as those have been ported to greentea. |
I'll start CI once netsocket is in (fixing CI) |
@gpsimenos PR approved but you still need to update "Impact of changes" |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
3070ebc
to
fe7ae8a
Compare
Rebased again. |
All comments have been addressed. Let's run CI. |
CI started |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
Summary of changes
mbed-os/events
directory restructured according to the internal proposal.mbed-os/events/include/events
foldermbed-os/events/tests/UNITTESTS
foldermbed-os/events/tests/TESTS
foldermbed-os/events/tests/unit
folderThis is one of a series of PRs aiming to clean up the mbed-os directory structure. The intention is to create a consistent tree among mbed components, following the below structure:
Impact of changes
'Local' unit tests (previously in
events/source/tests
) are duplicates of newer greentea tests and thus have been removed. The profiling tests (previously also inevents/source/tests
) have been moved tombed-os/events/tests/unit
. To run them, cd into the new location and runmake prof
.Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@evedon
@ashok-rao
@LDong-Arm