Skip to content

Nuvoton: Revise the pin name of M263A button #13325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Nuvoton: Revise the pin name of M263A button #13325

merged 1 commit into from
Jul 22, 2020

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

Revise the pin name of M263A button to match existing NUMAKER-IOT-M263A v1.1 schematic.

Documentation 

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Jul 21, 2020
0xc0170
0xc0170 previously approved these changes Jul 21, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2020

@cyliangtw can you rebase please, we fixed license check with travis (python dep breakage) ?

@mergify mergify bot dismissed 0xc0170’s stale review July 21, 2020 12:52

Pull request has been modified.

@cyliangtw
Copy link
Contributor Author

@0xc0170 , Yes, it's fine and I finished rebase just now.

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 21, 2020
@ciarmcom ciarmcom requested a review from a team July 21, 2020 13:00
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit efae402 into ARMmbed:master Jul 22, 2020
@mergify mergify bot removed the ready for merge label Jul 22, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
@cyliangtw cyliangtw deleted the nvt_m263_button branch October 5, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyliangtw @0xc0170 @ciarmcom @mbed-ci @mbedmain