CMake: Fix travis using tools #13311

0xc0170 · 2020-07-20T09:28:18Z

Summary of changes

Travis broke with the recent commits, we shall use mbed-tools from now on to export cmake and build.

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

0xc0170 · 2020-07-20T09:35:45Z

For anyone watching this branch, please use the commands to build blinky (other examples will be fixed).

mbedtools configure -t GCC_ARM -m K64F
cd build && cmake .. -GNinja -DMBED_PROFILE=develop && ninja

0xc0170 · 2020-07-20T09:37:05Z

Syntax error, fixed

hugueskamba · 2020-07-20T09:41:03Z

I tried to build Blinky as specified in the script but I got the following error:

user at hostname in /path/to/mbed-os-example-blinky on feature-cmake
$ mbedtools configure -t GCC_ARM -m K64F
mbed_config.cmake has been generated and written to '/path/to/mbed-os-example-blinky/.mbedbuild'
user at hostname in /path/to/mbed-os-example-blinky on feature-cmake
$ cd build/
user at hostname in /path/to/mbed-os-example-blinky/build on feature-cmake
$ cmake .. -GNinja -DMBED_PROFILE=develop
CMake Error at mbed-os/cmake/app.cmake:84 (add_custom_command):
  add_custom_command called with wrong number of arguments.
Call Stack (most recent call first):
  CMakeLists.txt:10 (include)
CMake Error at mbed-os/cmake/app.cmake:85 (add_custom_command):
  add_custom_command called with wrong number of arguments.
Call Stack (most recent call first):
  CMakeLists.txt:10 (include)
-- Configuring incomplete, errors occurred!
See also "/path/to/mbed-os-example-blinky/build/CMakeFiles/CMakeOutput.log".
See also "/path/to/mbed-os-example-blinky/build/CMakeFiles/CMakeError.log".

rwalton-arm · 2020-07-20T09:43:18Z

I tried to build Blinky as specified in the script but I got the following error:

user at hostname in /path/to/mbed-os-example-blinky on feature-cmake
$ mbedtools configure -t GCC_ARM -m K64F
mbed_config.cmake has been generated and written to '/path/to/mbed-os-example-blinky/.mbedbuild'
user at hostname in /path/to/mbed-os-example-blinky on feature-cmake
$ cd build/
user at hostname in /path/to/mbed-os-example-blinky/build on feature-cmake
$ cmake .. -GNinja -DMBED_PROFILE=develop
CMake Error at mbed-os/cmake/app.cmake:84 (add_custom_command):
  add_custom_command called with wrong number of arguments.
Call Stack (most recent call first):
  CMakeLists.txt:10 (include)
CMake Error at mbed-os/cmake/app.cmake:85 (add_custom_command):
  add_custom_command called with wrong number of arguments.
Call Stack (most recent call first):
  CMakeLists.txt:10 (include)
-- Configuring incomplete, errors occurred!
See also "/path/to/mbed-os-example-blinky/build/CMakeFiles/CMakeOutput.log".
See also "/path/to/mbed-os-example-blinky/build/CMakeFiles/CMakeError.log".

The tools config doesn't touch add_custom_command - are your mbed-os and example-blinky up to date?

rwalton-arm · 2020-07-20T09:43:43Z

.travis.yml

@@ -113,13 +113,15 @@ matrix:
        - source_pkg gcc
        - arm-none-eabi-gcc --version
        - pip install --user --upgrade cmake
+        - pip install --user --upgrade mbed-tools
        - >-
         git clone --depth=1 --single-branch --branch feature-cmake https://github.com/ARMmbed/mbed-os-example-blinky.git;
         cd mbed-os-example-blinky;


We'll need to add .mbed file

just about to add it. can we fix the tool or we fix it here for now?

I'd suggest we fix it here for now until we can all discuss what we want to do in the tools going forward (perhaps on Wednesday when @Patater returns from holiday).

hugueskamba · 2020-07-20T09:46:55Z

The tools config doesn't touch add_custom_command - are your mbed-os and example-blinky up to date?

@rwalton-arm Yes, I fetched and pulled this morning. There are custom commands in cmake/app.cmake.

rwalton-arm · 2020-07-20T09:53:14Z

The tools config doesn't touch add_custom_command - are your mbed-os and example-blinky up to date?

@rwalton-arm Yes, I fetched and pulled this morning. There are custom commands in cmake/app.cmake.

Yeah but I don't think the generated config affects them. Did you pull after #13286 was merged?

0xc0170 · 2020-07-20T10:05:13Z

I added .mbed creation as we manually fetch mbed-os for now

0xc0170 · 2020-07-20T10:07:32Z

@rwalton-arm @hugueskamba Please review

ciarmcom · 2020-07-20T11:00:33Z

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

hugueskamba · 2020-07-20T11:19:30Z

.travis.yml

         mkdir -p build;
      script:
-        - cd build && cmake .. -GNinja && ninja
+        - cd build && cmake .. -GNinja -DMBED_PROFILE=develop && ninja


Suggested change

- cd build && cmake .. -GNinja -DMBED_PROFILE=develop && ninja

- cd build && cmake .. -GNinja -DMBED_PROFILE=develop && cmake --build .

This command is a generic, cross-platform wrapper to the native build command for the chosen generator, ninja in this case.

We need config generation as part of the export, thus need to use tools from now on. Blinky was already updated.

0xc0170 · 2020-07-20T11:25:46Z

rebased, if this fails with only file missing, I'll merge to feature-branch, another PR incoming to fix this error

0xc0170 requested a review from a team July 20, 2020 09:28

mergify bot added the release-version: feature branch label Jul 20, 2020

0xc0170 force-pushed the fix_travis_using_tools branch from a856e61 to bbd66a5 Compare July 20, 2020 09:36

0xc0170 added the needs: review label Jul 20, 2020

mergify bot added needs: work and removed needs: review labels Jul 20, 2020

rwalton-arm reviewed Jul 20, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jul 20, 2020

0xc0170 force-pushed the fix_travis_using_tools branch from 2aaa04c to d3914c4 Compare July 20, 2020 10:52

mergify bot added needs: work and removed needs: CI labels Jul 20, 2020

ciarmcom requested a review from a team July 20, 2020 11:00

ciarmcom added the needs: review label Jul 20, 2020

0xc0170 removed the needs: work label Jul 20, 2020

hugueskamba reviewed Jul 20, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review labels Jul 20, 2020

travis: fix travis build by using mbedtools

b9d9b01

We need config generation as part of the export, thus need to use tools from now on. Blinky was already updated.

0xc0170 force-pushed the fix_travis_using_tools branch from 0d1b602 to b9d9b01 Compare July 20, 2020 11:25

0xc0170 added needs: CI and removed needs: work labels Jul 20, 2020

mergify bot added needs: work and removed needs: CI labels Jul 20, 2020

0xc0170 merged commit d863054 into ARMmbed:feature-cmake Jul 20, 2020

0xc0170 removed the needs: work label Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CMake: Fix travis using tools #13311

CMake: Fix travis using tools #13311

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

hugueskamba commented Jul 20, 2020

Uh oh!

rwalton-arm commented Jul 20, 2020

Uh oh!

rwalton-arm Jul 20, 2020

Uh oh!

0xc0170 Jul 20, 2020

Uh oh!

rwalton-arm Jul 20, 2020

Uh oh!

hugueskamba commented Jul 20, 2020 •

edited

Loading

Uh oh!

rwalton-arm commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

ciarmcom commented Jul 20, 2020

Uh oh!

hugueskamba Jul 20, 2020

Uh oh!

0xc0170 Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

Uh oh!

	- cd build && cmake .. -GNinja -DMBED_PROFILE=develop && ninja
	- cd build && cmake .. -GNinja -DMBED_PROFILE=develop && cmake --build .

CMake: Fix travis using tools #13311

CMake: Fix travis using tools #13311

Uh oh!

Conversation

0xc0170 commented Jul 20, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

hugueskamba commented Jul 20, 2020

Uh oh!

rwalton-arm commented Jul 20, 2020

Uh oh!

rwalton-arm Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

rwalton-arm Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

hugueskamba commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwalton-arm commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

ciarmcom commented Jul 20, 2020

Uh oh!

hugueskamba Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 20, 2020

Uh oh!

Uh oh!

hugueskamba commented Jul 20, 2020 •

edited

Loading