Skip to content

Remove MTS_DRAGONFLY_F411RE post binary hook that adds the bootloader #13301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

felser
Copy link
Contributor

@felser felser commented Jul 15, 2020

Summary of changes

Removed the post binary hook for MTS_DRAGONFLY_F411RE that adds the bootloader to the application. Adding a bootloader will not be accomplished by specifying it in mbed_app.json. This allows any bootloader to be added.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Built blinky with the post binary hook removed. Tested with and without a bootloader specified in mbed_app.json. All bin files with and without the bootloader run on the target. Also loaded application only files using the bootloader ymodem method.

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 15, 2020
@ciarmcom ciarmcom requested a review from a team July 15, 2020 21:00
@ciarmcom
Copy link
Member

@felser, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jul 16, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Jul 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@mergify
Copy link

mergify bot commented Jul 17, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot added the needs: work label Jul 17, 2020
@adbridge
Copy link
Contributor

@felser looks like this needs a rebase ?

@felser
Copy link
Contributor Author

felser commented Jul 17, 2020

I can if you think it's necessary. I'm only removing the section for the post binary hook. Not touching anything else. So the conflict is very easy to resolve. Is that something you can do... just remove the binary hook section?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2020

@felser The pull request needs a rebase, it should be quick fix.

As this is touching only target.json, the change should be OK to go in (compare to #13135).

@felser felser force-pushed the dragonfly-post-hook branch from 0425ed1 to c946c2a Compare July 20, 2020 19:17
@mergify mergify bot dismissed 0xc0170’s stale review July 20, 2020 19:18

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 3d0e5a9 into ARMmbed:master Jul 22, 2020
@mergify mergify bot removed the ready for merge label Jul 22, 2020
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants