MASTER - LICENSE.md - clarify filesystem licensing #13276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanneKiiskila, thank you for your changes. |
|
Thanks !
👍 |
0xc0170
previously requested changes
Jul 13, 2020
LICENSE.md
Outdated
| @@ -14,7 +14,8 @@ Folders containing files under different permissive license than Apache 2.0 are | |||
| - [features/lorawan](./features/lorawan) - Revised BSD | |||
| - [features/lwipstack](./features/lwipstack) - BSD-style, MIT-style | |||
| - [features/nanostack/sal-stack-nanostack](./features/nanostack/sal-stack-nanostack) - BSD-3-Clause | |||
| - [features/storage](./features/storage) - BSD-style, MIT | |||
| - [features/storage/filesystem/littlefs](./features/storage/filesystem/littlefs) - [BSD-3-Clause](https://github.com/ARMmbed/littlefs/blob/master/LICENSE.md) | |||
| - [features/storage/filesystem/fat/ChaN](.features/storage/filesystem/fat/ChaN) - BSD-style, 1 clause, [Copyright ChaN](http://www.elm-chan.org/fsw/ff/doc/appnote.html) | |||
There was a problem hiding this comment.
One note: some of the files in features\storage\blockdevice are released under MIT. Lets add it as well
0xc0170
previously approved these changes
Jul 16, 2020
0xc0170
added
needs: CI
release-type: patch
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
|
@JanneKiiskila could you rebase this please |
added 2 commits
July 17, 2020 13:33
We should really specify the littlefs and FAT FS licensing as separate items, we should not just lump them together. I also think we should point where the originals were picked up from.
They are a seemingly random mix of Apache 2.0 and MIT licenses.
JanneKiiskila
force-pushed
the
master-license-fat
branch
from
2d85741 to
0a2d5ff
Compare
|
Rebased. |
0xc0170
approved these changes
Jul 20, 2020
|
Quick Ci check and should be good to go in |
mbedmain
added
release-version: 6.2.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should really specify the littlefs and FAT FS licensing as separate
items, we should not just lump them together.
I also think we should point where the originals were picked up from.
Impact of changes
Documentation.
Migration actions required
None.
Documentation
Self-documenting.
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-maintainers @geky