Skip to content

Move drivers from components to connectivity #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

We are gradually migrating connectivity features (e.g. WiFi, cellular, BLE, etc.) to a new directory structure:

connectivity
├── wifi
├── cellular
├── [...]
├── drivers       // target drivers
│   ├── wifi
│   ├── cellular
│   ├── [...]

This PR moves the existing WiFi, cellular and 802.15.4_RF drivers from components/ to the newly proposed connectivity/drivers/ directory.

Not covered: BLE, NFC & drivers outside components/ - to be covered by separate PRs.

Impact of changes

Migration actions required

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing (compilation):

  • WiFi: mbed-os-example-wifi for NUCLEO_F429ZI - esp8266-driver
  • cellular: mbed-os-example-cellular for DISCO_L496AG - COMPONENT_STMOD_CELLULAR
  • 802.15.4_RF: nanostack-border-router for any target - atmel-rf-driver

Reviewers

@ARMmbed/mbed-os-core @bulislaw @0xc0170


@ciarmcom ciarmcom requested review from 0xc0170, bulislaw and a team July 6, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 6, 2020

@LDong-Arm, thank you for your changes.
@0xc0170 @bulislaw @ARMmbed/mbed-os-maintainers please review.

@LDong-Arm LDong-Arm changed the title Mv drivers from components to connectivity Move drivers from components to connectivity Jul 6, 2020
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 9, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

Re-running ci as this passed 8 days ago

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 2bd3c96 into ARMmbed:master Jul 17, 2020
@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed ready for merge labels Jul 17, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants