Skip to content

Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setup' in a local #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setup' in a local #13184

merged 1 commit into from
Jul 28, 2020

Conversation

supertoast
Copy link

@supertoast supertoast commented Jun 24, 2020 •
edited by hugueskamba
Loading

Summary of changes

gpiote input configuration data structure, resulting in non-deterministic failure
to initialize interrupt handling.

Backport (cherry-pick) fix for NRF52 (#12431) to Mbed OS 5.15.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@werelizzard
Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setu…
b9260ae 
…p' in a local

gpiote input configuration data structure, resulting in non-deterministic failure
to initialize interrupt handling.
@supertoast supertoast mentioned this pull request Jun 24, 2020
Closed
@mergify mergify bot added the needs: CI label Jun 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage-lts

@0xc0170 0xc0170 requested a review from andypowers July 1, 2020 09:48
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2020

I restarted dynamic memory, should be green

@hugueskamba hugueskamba changed the title Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setu… Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setup' in a local Jul 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jul 22, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

@adbridge
Copy link
Contributor

Approved by @andypowers

@adbridge adbridge merged commit 9ab68b9 into ARMmbed:mbed-os-5.15 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers Awaiting requested review from andypowers

Assignees
No one assigned
Labels
release-version: 5.15.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supertoast @0xc0170 @mbed-ci @adbridge