Skip to content

EMAC: Fix Chrono compliation warnings #13142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2020
Merged

EMAC: Fix Chrono compliation warnings #13142

merged 2 commits into from
Jun 19, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 17, 2020 •
edited
Loading

Summary of changes

Fixed the Chrono compilation warning in EMAC drivers by using Chrono based time argument in EventQueue call_every() API call.

Impact of changes

With these changes, no more compilation warning get reported during the build.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team June 17, 2020 17:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the coding style should be a separate commit, please update.

What warnings is this fixing ? Can you add the details to the commit message?

@rajkan01 rajkan01 force-pushed the fix_emac_chrono_warning branch from 83256ee to 28e44ac Compare June 18, 2020 11:35
@mergify mergify bot dismissed 0xc0170’s stale review June 18, 2020 11:35

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Jun 18, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2020

CI started

@mergify mergify bot dismissed 0xc0170’s stale review June 18, 2020 11:41

Pull request has been modified.

@rajkan01
Copy link
Contributor Author

Fixing the coding style should be a separate commit, please update.
What warnings is this fixing ? Can you add the details to the commit message?

Done.

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2020

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 18, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 18, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 15b7fe4 into ARMmbed:master Jun 19, 2020
@0xc0170 0xc0170 removed the needs: CI label Jun 19, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @adbridge