-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: Fix privacy and signing handling in Security Manager #13037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a1d055c
to
0506d99
Compare
@paul-szczepanek-arm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is confusing, I review these changes in #13038. Anyway all good except it may not be the best thing to write the local sign counter whenever it is changed.
So, before this, enabling privacy did not actually change the advertised address of the device? What I was seeing in the past was the device would advertise that it was using a random resolvable address but it always had the same MAC address. This was causing pairing issues with non-Mbed-OS devices (ie: iOS and Android) |
`idenitty type in the first commit. Otherwise looks fine to me. I would add also this
to the first commit. |
Initialises identity addres when privacy is enabled. Stores the identity. Retrieves local identity if previously stored.
76b5dea
to
9d54c56
Compare
I have broken up commits into logical steps and expanded the commit messages |
Sorry for the delay in all these BLE fixes, all should get CI time today. |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten. |
Summary of changes
This fixes handling of identity addresses when privacy is enabled by the ble security manager. A new call allows to retrieve peer identity address and local data is being stored in the db. It also fixes the initialisation of said identity address.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@pan-