Skip to content

Nuvoton: Fix watchdog reset failure on meeting Hard Fault (5.15) #12969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Nuvoton: Fix watchdog reset failure on meeting Hard Fault (5.15) #12969

merged 1 commit into from
Jun 9, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented May 14, 2020

Summary of changes

This PR is backport of #12896 into Mbed OS 5.15.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: Fix watchdog reset failure on meeting Hard Fault
9c59bd0 
Original implementation doesn't enable watchdog reset in pieces of cascaded timeout, except the last one. This is to guarantee re-configuration can be in time, but in interrupt disabled scenario e.g. Hard Fault, watchdog reset can cease to be effective.

This change enables watchdog reset all the way of cascaded timeout. With trade-off, guaranteed watchdog reset function is more significant than re-configuration in time.
@ciarmcom ciarmcom requested a review from a team May 14, 2020 05:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers June 4, 2020 13:20
andypowers
andypowers approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Jun 9, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM-lts

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 8e59768 into ARMmbed:mbed-os-5.15 Jun 9, 2020
@mergify mergify bot removed the ready for merge label Jun 9, 2020
@ccli8 ccli8 deleted the nuvoton_5.15_watchdog_hardfault branch June 9, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @andypowers