Clean-up S2LP driver configuration

[MarceloSalazar]

Summary of changes

This PR adds the ability to configure the pins of the S2LP driver for any target (inside Mbed OS or custom target) using the standard mbed_lib.json and mbed_app.json config files.

Additionally, the MTB_STM_S2LP and MTB_STM_S2LP_CT targets are removed as are not supported in Mbed OS 6, and thus making the S2LP driver independent of targets.

Impact of changes

Note users can continue to use the 5.15 branch.
For Mbed OS 6, it should be possible to use the default pin config without changes (apart from MTBs).
Custom pin configuration can be done as shown next.

Migration actions required

Developers need to create a mbed_app.json (or other json config) including the pin configuration for their target.

An example of application configuration for the S2LP driver is shown here:
https://github.com/MarceloSalazar/mbed-os-example-mesh-minimal/blob/S2LP_cleanup/configs/mesh_wisun_S2LP.json#L34-L50

        "NUCLEO_F429ZI":  {
            "LED": "LED_RED",
            "BUTTON": "USER_BUTTON",
            "BUTTON_MODE": "PullDown",
            "s2lp.SPI_SDI"           : "PA_7",
            "s2lp.SPI_SDO"           : "PA_6",
            "s2lp.SPI_SCLK"          : "PA_5",
            "s2lp.SPI_CS"            : "PC_0",
            "s2lp.SPI_SDN"           : "PF_13",
            "s2lp.SPI_GPIO0"         : "PA_3",
            "s2lp.SPI_GPIO1"         : "PC_3",
            "s2lp.SPI_GPIO2"         : "PF_3",
            "s2lp.SPI_GPIO3"         : "PF_10",
            "s2lp.I2C_SDA"           : "PB_7",
            "s2lp.I2C_SCL"           : "PB_6",
            "s2lp.provide-default"   : true
        }

The driver can be initialized as follow:

NanostackRfPhys2lp rf_phy(MBED_CONF_S2LP_SPI_SDI
                          ,MBED_CONF_S2LP_SPI_SDO
                          ,MBED_CONF_S2LP_SPI_SCLK
                          ,MBED_CONF_S2LP_SPI_CS
                          ,MBED_CONF_S2LP_SPI_SDN
                          ,MBED_CONF_S2LP_SPI_GPIO0
                          ,MBED_CONF_S2LP_SPI_GPIO1
                          ,MBED_CONF_S2LP_SPI_GPIO2
                          ,MBED_CONF_S2LP_SPI_GPIO3);

Documentation

None

---

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Note that mbed-os-example-mesh-minimal and nanostack-border-router applications compile ok when using provided mesh_wisun_S2LP.json config:

mbed compile -t ARM -m NUCLEO_F429ZI --app-config configs/mesh_wisun_S2LP.json -c

---

Reviewers

---

[ciarmcom]

@MarceloSalazar, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-ipcore please review.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_wisun-mesh-test

[0xc0170]

@MarceloSalazar wisun tests failing - using most probably something that this PR changes

[MarceloSalazar]

@0xc0170 correct - there is a dependency and wisun tests will have to be updated as indicated in the migration section

[mergify]

This PR cannot be merged due to conflicts. Please rebase to resolve them.

[MarceloSalazar]

Rebased and fixed issues

Pull request has been modified.

[mbed-ci]

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_wisun-mesh-test

[MarceloSalazar]

The error is expected - there is a need to migrate to use the Mbed configuration as indicated in the guide above.

NanostackRfPhys2lp rf_phy(S2LP_SPI_SDI, S2LP_SPI_SDO, S2LP_SPI_SCLK, S2LP_SPI_CS, S2LP_SPI_SDN,

./drivers/rf_wrapper.cpp:27:41: error: 'S2LP_SPI_SDO' was not declared in this scope

Change needed here: https://github.com/ARMmbed/nanostack-border-router/blob/master/drivers/rf_wrapper.cpp#L27

[MarceloSalazar]

I've added support for legacy pin configuration, so the nanostack-border-router app continues to work as it's. It's possible to override the config using mbed_app.json as shown in the description above.

Please re-test.

[0xc0170]

CI restarted

[mbed-ci]

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 6
Build artifacts

[mergify]

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Pull request has been modified.

[MarceloSalazar]

Rebased and fixed.

[0xc0170]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 7
Build artifacts

[andypowers]

Approved