Skip to content

ARCH_PRO: Remove uARM tooolchain support #12853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

ARCH_PRO: Remove uARM tooolchain support #12853

merged 1 commit into from
Apr 29, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Apr 23, 2020 •
edited
Loading

Summary of changes

  • Update scatter file for the ARM toolchain to use 2 region memory model.
    The scatter file changes affect the following boards:
    • LPC1768, ARCH_PRO, UBLOX_C027, XBED_LPC1768 (LPC1768.sct)
  • Remove the TOOLCHAIN_ARM_MICRO directory.
  • Remove release_version as not necessary and as the target can also run
    Mbed OS 6.
  • Remove uARM toolchain in the list of supported toolchains for the target.
  • Indicate that the target supports the small ARM toolchain C library.

Impact of changes

It is no longer possible to use the uARM toolchain to build binaries for the ARCH_PRO board.

Migration actions required

Set the "target.c_lib" configuration option to "small" to build binaries using Microlib with the ARM toolchain.

Documentation

N/A

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Running the Greentea tests with mbed test -t arm -m ARCH_PRO completed successfully

Reviewers

@bulislaw @evedon

0xc0170
0xc0170 reviewed Apr 23, 2020
View reviewed changes
targets/targets.json
@@ -583,10 +582,6 @@
"WATCHDOG",
"RESET_REASON"
],
"release_versions": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this already somehow deprecated and we dont use it ? I recall tools relied on this information

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not be used in Mbed 6. More information coming in the Mbed 2 target porting guide. Currently it only really matters for Mbed 2 only targets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I havent seen that update. I assume the clean up will come for all targets (just removing release version).

cc @MarceloSalazar

Copy link
Contributor

@evedon evedon Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you did not need to override supported_c_libs to build with Microlib?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ciarmcom ciarmcom requested review from bulislaw, evedon, maclobdell and a team April 23, 2020 13:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@bulislaw @evedon @maclobdell @ARMmbed/mbed-os-maintainers please review.

@MarceloSalazar MarceloSalazar requested a review from ytsuboi April 24, 2020 09:59
@MarceloSalazar
Copy link

@ytsuboi please have a look - I understand this is a board you're supporting :)
FYI @toyowata

@MarceloSalazar MarceloSalazar removed the request for review from maclobdell April 24, 2020 10:01
@hugueskamba hugueskamba force-pushed the hk_remove_uarm_nxp_board branch from 868f574 to b23c59d Compare April 24, 2020 10:44
@hugueskamba
Copy link
Collaborator Author

This force-push updates the commit message to list all affected boards.

0xc0170
0xc0170 previously approved these changes Apr 24, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Apr 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mergify mergify bot added needs: work and removed needs: CI labels Apr 27, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

I'll restart master testing later today (the failure was known issue with one PR an example, fixed now)

@hugueskamba
ARCH_PRO: Remove uARM tooolchain support
58c8d62 
* Update scatter file for the ARM toolchain to use 2 region memory model.
  The scatter file changes affect the following boards:
    * LPC1768, ARCH_PRO, UBLOX_C027, XBED_LPC1768 (LPC1768.sct)
* Remove the TOOLCHAIN_ARM_MICRO directory.
* Remove release_version as not necessary and as the target can also run
  Mbed OS 6.
* Remove uARM toolchain in the list of supported toolchains for the target.
* Indicate that the target supports the small ARM toolchain C library.
@hugueskamba hugueskamba force-pushed the hk_remove_uarm_nxp_board branch from b23c59d to 58c8d62 Compare April 28, 2020 00:30
@mergify mergify bot dismissed 0xc0170’s stale review April 28, 2020 00:31

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 28, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 761b546 into ARMmbed:master Apr 29, 2020
@mergify mergify bot removed the ready for merge label Apr 29, 2020
@hugueskamba hugueskamba deleted the hk_remove_uarm_nxp_board branch April 30, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

@ytsuboi ytsuboi Awaiting requested review from ytsuboi

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @MarceloSalazar @0xc0170 @mbed-ci @evedon