USBMSD security updates #12693
Merged
USBMSD security updates #12693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix protects underlaying block device from out-of-bound read/writes - prevents the host from setting block device addres larger then block device size - prevents the host from setting wrong read/write lenght
Fix protects underlaying block device from out-of-bound reads
Fix prevents unaligned USB transfers
ciarmcom
requested review from
bulislaw,
c1728p9,
donatieng,
jamesbeyond and
a team
|
@maciejbocianski, thank you for your changes. |
|
@maciejbocianski please explain what each fix is and why it is required in the header |
adbridge
approved these changes
Mar 26, 2020
|
CI started |
jamesbeyond
approved these changes
Mar 26, 2020
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
|
This PR does not contain release version label after merging. |
mergify
bot
added
the
release version missing
|
We need to back port this fix on 5.15 LTS @0xc0170 |
|
@Mergifyio backport mbed-os-5.15 |
0xc0170
removed
the
release version missing
|
Command
|
|
Magic! 😮 |
0xc0170
added a commit
that referenced
this pull request
Apr 7, 2020
USBMSD security updates (bp #12693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Couple of USB MSD fixes improving security:
update USBMSD::infoTransfer implementation ac105f5
Fix protects underlaying block device from out-of-bound read/writes
update USBMSD::memoryRead implementation 89e67d3
Fix protects underlaying block device from out-of-bound reads
update USBMSD::memoryWrite implementation 1ffb4d7
Fix prevents unaligned USB transfers
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@c1728p9 @bulislaw @donatieng @jamesbeyond