Skip to content

Remove ARMC5 reference from Mbed OS platform #12655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

Remove ARMC5 reference from Mbed OS platform #12655

merged 1 commit into from
Mar 20, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 19, 2020 •
edited
Loading

Summary of changes

Removed ARMC5 reference from Mbed OS platform.

Impact of changes

Breaking change: The ARMC5 references are removed from platform as they have been deprecated in a previous Mbed OS release.

Migration actions required

Use Arm Compiler 6

Documentation

None.

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon, @kjbracey-arm, @bulislaw

@mergify mergify bot added the needs: work label Mar 19, 2020
@ciarmcom ciarmcom requested review from evedon and a team March 19, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon
evedon reviewed Mar 19, 2020
View reviewed changes
@rajkan01 rajkan01 force-pushed the ARMC5_remove_platform branch from c1ef7fb to f7f8fcb Compare March 19, 2020 17:33
@rajkan01 rajkan01 force-pushed the ARMC5_remove_platform branch from f7f8fcb to eb40dbc Compare March 19, 2020 17:48
@ciarmcom ciarmcom requested review from evedon and a team March 19, 2020 18:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon
evedon approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Would be good if @kjbracey-arm could review.

@evedon
Copy link
Contributor

evedon commented Mar 20, 2020

It would be good to start CI on this one @adbridge

@adbridge
Copy link
Contributor

CI Started

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 890a12a into ARMmbed:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajkan01 @ciarmcom @evedon @adbridge @mbed-ci