Skip to content

Minor optimization to improve readability of code #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2020
Merged

Minor optimization to improve readability of code #12537

merged 5 commits into from
Mar 4, 2020

Conversation

DavidLin1577
Copy link
Contributor

Summary of changes

Most functions in lowpan_context.h/c named with 'context',
except the function 'lowpan_contex_get_by_id ()' named with 'contex',
so replace 'contex' with 'context' to improve readability.

Impact of changes

Migration actions required

Documentation

Pull request type 

[*] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[*] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@DavidLin1577
Fix function spelling mistake in lowpan_context.h
5a883a2 
lowpan_contex_get_by_id -> lowpan_context_get_by_id
@DavidLin1577
Fix function spelling mistake in lowpan_context.c
c2e649a 
lowpan_contex_get_by_id -> lowpan_context_get_by_id
@DavidLin1577
Fix function spelling mistake in iphc_decompress.c
d76df4c 
lowpan_contex_get_by_id -> lowpan_context_get_by_id
@DavidLin1577
Fix function spelling mistake in border_router.c
922452d 
lowpan_contex_get_by_id -> lowpan_context_get_by_id
@DavidLin1577
Fix function spelling mistake in Thread
d5f4b8e 
lowpan_contex_get_by_id -> lowpan_context_get_by_id
@ciarmcom ciarmcom requested review from a team February 29, 2020 06:00
@ciarmcom
Copy link
Member

@DavidLin1577, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from artokin March 2, 2020 09:08
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 2, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 3, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 3, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 merged commit 0542b40 into ARMmbed:master Mar 4, 2020
@mergify mergify bot removed the ready for merge label Mar 4, 2020
@DavidLin1577 DavidLin1577 deleted the patch-8 branch March 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@artokin artokin artokin approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DavidLin1577 @ciarmcom @0xc0170 @mbed-ci @artokin