STM32F7: linker scripts updates #11870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
bulislaw
approved these changes
Nov 15, 2019
|
Hi |
0xc0170
reviewed
Nov 19, 2019
| * Copyright (c) 2016-2019 STMicroelectronics. | ||
| * All rights reserved. | ||
| * | ||
| * This software component is licensed by ST under BSD 3-Clause license, |
There was a problem hiding this comment.
Can you add SPDX identifier to files with he license like this one? Otherwise we need to create own rules to get the license like this (as it only references the license similar to SPDX)
|
Otherwise looks good, so once updated, we shall start CI asap |
- license header - DTCM RAM use - alignment within the STM32F7 family
jeromecoutant
force-pushed
the
PR_F7_LINKER
branch
from
3972496 to
82a9628
Compare
done |
0xc0170
approved these changes
Nov 22, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Since #11711, DTCM-RAM was used only for vectors.
This could make some regression for applications.
(ex with https://os.mbed.com/teams/ST/code/DISCO-F769NI_AUDIO_demo/)
Summary of change (What the change is for and why)
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required