-
Notifications
You must be signed in to change notification settings - Fork 3k
Update Cypress WifiHostDriver to version 1.50 #11840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@morser499, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move WHD from being identified as a Target to being a Component
Please send this separately, it's hard to review when you move and change files within one PR. Can this PR be just about updating the driver?
I don't understand what splitting it up would achieve. Can you clarify? The changes are already split up into separate commits and can be viewed individually: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the majority of the PR is only changing target code which we do not really review. Someone in the WiFi team may just wish to check the general principle of moving from target to component and the impact on the targets.json file however...
I think it is OK to move the code to COMPONENTS, if they wish. I don't see the point of splitting this PR, I would accept this as it is. Looks fine. |
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
@morser499 Please review build failures |
Updated BLE feature to use component instead of target as well. The remaining failures appear to be because the MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD are not defined. Did something change in the application related to these values? |
eab475f
to
977cf05
Compare
The next restart will show us, but should not be there (as this is not supported error , not real error but sometimes I noticed it in the logs being printed along iwth the real error). Restarted CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description (required)
Update the Cypress Wifi Host Driver (WHD) to version 1.50.
Summary of change (What the change is for and why)
Add support for Manufacturing Test
Update 43012 firmware images
Move WHD from being identified as a Target to being a Component
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
CYW9P62S1_43012EVB_01-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt
CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_062_4343W-GCC_ARM.txt
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required