Skip to content

Update Cypress WifiHostDriver to version 1.50 #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

morser499
Copy link

Description (required)

Update the Cypress Wifi Host Driver (WHD) to version 1.50.

Summary of change (What the change is for and why)

Add support for Manufacturing Test
Update 43012 firmware images
Move WHD from being identified as a Target to being a Component

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

CYW9P62S1_43012EVB_01-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt
CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_062_4343W-GCC_ARM.txt


Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@ciarmcom ciarmcom requested review from maclobdell and a team November 8, 2019 02:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 8, 2019

@morser499, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move WHD from being identified as a Target to being a Component

Please send this separately, it's hard to review when you move and change files within one PR. Can this PR be just about updating the driver?

@morser499
Copy link
Author

Move WHD from being identified as a Target to being a Component

Please send this separately, it's hard to review when you move and change files within one PR. Can this PR be just about updating the driver?

I don't understand what splitting it up would achieve. Can you clarify? The changes are already split up into separate commits and can be viewed individually:
6c1c1cc

eab475f

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the majority of the PR is only changing target code which we do not really review. Someone in the WiFi team may just wish to check the general principle of moving from target to component and the impact on the targets.json file however...

@SeppoTakalo
Copy link
Contributor

I think it is OK to move the code to COMPONENTS, if they wish.

I don't see the point of splitting this PR, I would accept this as it is. Looks fine.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

@morser499 Please review build failures

@morser499
Copy link
Author

morser499 commented Nov 11, 2019

@morser499 Please review build failures

Updated BLE feature to use component instead of target as well. The remaining failures appear to be because the MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD are not defined. Did something change in the application related to these values?

@ifyall
Copy link

ifyall commented Nov 11, 2019

@0xc0170, There is a change in dfa9692 that impacted both MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD. Can that be causing the issue?

Ian

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

@0xc0170, There is a change in dfa9692 that impacted both MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD. Can that be causing the issue?

The next restart will show us, but should not be there (as this is not supported error , not real error but sometimes I noticed it in the logs being printed along iwth the real error).

Restarted CI

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants