Suppress Coverity warnings

[hugueskamba]

Description

Ignore the following Coverity warnings:

* cmsis_os1.c:270 Passing argument 4UL /* sizeof (void *) */ to function osMessageQueueNew which returns a value of type void * is suspicious.
* mbed_retarget.cpp:451 Argument cannot be negative (NEGATIVE_RETURNS). negative_returns: fd is passed to a parameter that cannot be negative. [Note: The source code implementation of the function has been overridden by a builtin model.]
* mbed_retarget.cpp:828 result_independent_of_operands: off > 2147483647 is always false regardless of the values of its operands. This occurs as the logical operand of if.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

[ciarmcom]

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

[evedon]

I don't understand the coverity warning.
Is it because std is missing?

std::FILE *stream = std::fdopen(fd, mode);

[hugueskamba]

Not sure but my wild guess is that it is related to IAR implementation of it...
GIven the end of the message (Note: The source code implementation of the function has been overridden by a builtin model.), it seems my guess could be right.

[kjbracey]

The diagnostic is correct - it's spotted that we could be passing a negative fd to ::fdopen.

(The "built-in model" bit is that it knows what ::fdopen is supposed to do, and it knows it shouldn't be getting a negative fd.)

Problem should be fixed by changing line 446 from if (!fd) to if (fd < 0). bind_to_fd returns negative on failure, not 0. 0 is actually a valid file descriptor, although it's reserved for console input.

[hugueskamba]

#11472 (comment)

[hugueskamba]

This force-push corrects the code where fdopen is used instead of silencing the warning.
I also removes "bogus" from the commit message.

[mbed-ci]

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_greentea-test

[0xc0170]

test restarted, internal issue