Skip to content

Stack type ip versions #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2019
Merged

Stack type ip versions #11424

merged 4 commits into from
Sep 13, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

  • Set stack type based on the network assigned IP addresses
  • Check send to address and stack compatibilty
  • IP stack property redefined to be distinct from PDP context type
  • Enable IPv6 stack support for BG96

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and a team September 5, 2019 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 5, 2019

@mirelachirica, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix, is it touching only internal functionality ? No functional changes to a user?

@mirelachirica
Copy link
Contributor Author

This is a fix, is it touching only internal functionality ? No functional changes to a user?

Only internal functionality. The change made to convert_ipv6() as part of CellularUtil is not part of our API.

Our documentation is stating: "As an application developer, you should use and refer only to classes located under API folder"
https://os.mbed.com/docs/mbed-os/v5.13/reference/cellular-networking.html

@kivaisan kivaisan mentioned this pull request Sep 11, 2019
Closed
@mirelachirica
Copy link
Contributor Author

This needs review. Could you @kivaisan @AnttiKauppila review?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-ARM

@mirelachirica
Copy link
Contributor Author

UNITTEST build issue fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 66c39e0 into ARMmbed:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@kivaisan kivaisan kivaisan approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila @kivaisan