Skip to content

Add SoftAP concurrency support #11321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add SoftAP concurrency support #11321

wants to merge 8 commits into from

Conversation

kyle-cypress
Copy link

Description

Enable SoftAP concurrency with Cypress WHD, along with associated code cleanup for PSoC6 targets.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@kyle-cypress kyle-cypress mentioned this pull request Aug 25, 2019
Closed
@ciarmcom ciarmcom requested review from a team August 25, 2019 01:01
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, these would be separate commits:

Clean up WHD WifiInterface
Update BSP Wifi implementation to accomodate interface changes
Restructure BSP files to reduce code duplication

Much easier to review and understand changes. Can you?

@kyle-cypress kyle-cypress force-pushed the pr/whd-softap-concurrency branch from f363e51 to 8caeed3 Compare August 26, 2019 21:20
@kyle-cypress
Copy link
Author

Ideally, these would be separate commits:

Clean up WHD WifiInterface
Update BSP Wifi implementation to accomodate interface changes
Restructure BSP files to reduce code duplication

Much easier to review and understand changes. Can you?

Restructured.

@kyle-cypress
Copy link
Author

This PR is dependent on #11324 and #11319

@kyle-cypress kyle-cypress mentioned this pull request Aug 27, 2019
Closed
@kyle-cypress kyle-cypress mentioned this pull request Aug 28, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

This PR is dependent on #11324 and #11319

Merged. Conflict now here

@kyle-cypress kyle-cypress mentioned this pull request Aug 28, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2019

Integrated via #11367

@0xc0170 0xc0170 closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyle-cypress @ciarmcom @0xc0170 @AnttiKauppila @cy-opm