-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: add nonscannable connectable type #11204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@paul-szczepanek-arm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @paul-szczepanek-arm
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@@ -446,6 +446,9 @@ struct advertising_event_properties_t { | |||
break; | |||
case advertising_type_t::ADV_NONCONN_IND: | |||
break; | |||
case advertising_type_t::ADV_NONSCAN_IND: | |||
connectable = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use_legacy_pdu
should be set too false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed it was, seeing as only a few lines above there's a:
use_legacy_pdu = true;
but apparently the default is already true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the default constructor does set it to false and either way it's irrelevant since the type shouldn't set it as it's set by an explicit passed in parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pal::advertising_event_properties_t event_properties(params.getType());
event_properties.use_legacy_pdu = params.getUseLegacyPDU();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this and the changes required to make this neat are outside of scope for this PR and functionally the code is correct.
Description
GAP was missing an advertising type that would allow to attach an extended advertising payload (non-legacy PDU) and also be connectable. This adds this type. This is caused by the limitation where extended pdu cannot be added to advertising that is both scannable and connectable.
Pull request type
Reviewers
@donatieng
Release Notes
Adds new type, existing functionality unchanged.