Skip to content

freescale: fix i2c_byte_read function #11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maciejbocianski
Copy link
Contributor

Description

Fix i2c_byte_read implementation for Freescale Xpresso targets
single byte read test gets stuck in i2c_byte_read while reading first byte

before:
| target       | platform_name | test suite                             | result  | elapsed_time (sec) | copy_method |
|--------------|---------------|----------------------------------------|---------|--------------------|-------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | TIMEOUT | 33.65              | default     |
mbedgt: test suite results: 1 TIMEOUT
mbedgt: test case report:
| target       | platform_name | test suite                             | test case                            | passed | failed | result | elapsed_time (sec) |
|--------------|---------------|----------------------------------------|--------------------------------------|--------|--------|--------|--------------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins        | 1      | 0      | OK     | 0.75               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API              | 1      | 0      | OK     | 0.45               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API  | 0      | 0      | ERROR  | 0.0                |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API             | 1      | 0      | OK     | 0.47               |

after:
| target       | platform_name | test suite                             | test case                            | passed | failed | result | elapsed_time (sec) |
|--------------|---------------|----------------------------------------|--------------------------------------|--------|--------|--------|--------------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins        | 1      | 0      | OK     | 0.75               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API              | 1      | 0      | OK     | 0.45               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API  | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API             | 1      | 0      | OK     | 0.47

obraz

Pull request type

[X] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and a team August 1, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 1, 2019

@maciejbocianski, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@maclobdell
Copy link
Contributor

@armmbed/team-nxp - please review

@SeppoTakalo SeppoTakalo requested a review from a team August 5, 2019 12:03
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mbed-ci
Copy link

mbed-ci commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants