NRF52 need to call TIMER_TASK_SHUTDOWN for current consumption #11123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@desmond-blue, thank you for your changes. |
|
Thanks @desmond-blue, |
|
@bulislaw I only ran the ticker/timer tests on nRF52840_DK, which is all I have. Could we access CI and run our own test job? |
|
I don't think we have this board in the CI at this stage. But your testing sounds like it should do for now. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since current consumption increased when the timer has been running and only the STOP task is used to stop on nRF52x, we need to call SHUTDOWN task after STOP task.
reference for nRF52840
reference for nRF52832
Pull request type
Reviewers
Release Notes