Nuvoton: Enlarge LPTICKER_DELAY_TICKS for safe #11021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). Enlarge LPTICKER_DELAY_TICKS to 4 from 3 to address this boundary case.
0xc0170
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). Enlarge LPTICKER_DELAY_TICKS to 4 from 3 to address this boundary case.
👍 what I asked in your earlier PR for deepsleep , this one to be there as well
|
Any update? |
|
Ci started |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Tracking issue for exporters failure: #11209 |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Nuvoton targets,
lp_ticker_set_interrupt(...)needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). This PR enlargesLPTICKER_DELAY_TICKSto 4 from 3 to address this boundary case.Pull request type