Windows makefile builds no longer work

[cmonr]

Description

Exporting projects to a make_* ide, and running make no longer appears to work since #7183 came in (confirmed via git bisect).

This has been validated with make_armc5 and make_gcc_arm "IDEs".

PRs #7583 and #7559 do not fix the issue.

Output

C:\Users\redacted\test\mbed-os-example-blinky>(cd mbed-os && git checkout master && cd ..)
Already on 'master'
Your branch is up-to-date with 'origin/master'.

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_gcc_arm -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:865: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:857: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
../main.cpp:1:18: fatal error: mbed.h: No such file or directory
 #include "mbed.h"
                  ^
compilation terminated.
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_armc5 -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:861: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:852: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
"../main.cpp", line 1: Error:  #5: cannot open source input file "mbed.h": No such file or directory
../main.cpp: 0 warnings, 1 error
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>(cd mbed-os && git checkout pr7583 && cd ..)
Switched to branch 'pr7583'

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_gcc_arm -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:865: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:857: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
../main.cpp:1:18: fatal error: mbed.h: No such file or directory
 #include "mbed.h"
                  ^
compilation terminated.
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_armc5 -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:861: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:852: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
"../main.cpp", line 1: Error:  #5: cannot open source input file "mbed.h": No such file or directory
../main.cpp: 0 warnings, 1 error
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>(cd mbed-os && git checkout pr7559 && cd ..)
Switched to branch 'pr7559'

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_gcc_arm -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:1305: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:1297: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
arm-none-eabi-g++.exe: fatal error: no input files
compilation terminated.
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>pipenv run mbed export -i make_armc5 -m K64F --clean && make
Scan: mbed-os-example-blinky
C:/Users/root/test/mbed-os-example-blinky/makefile:1097: warning: overriding commands for target `.s.o'
C:/Users/root/test/mbed-os-example-blinky/makefile:1088: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
Error: C4079E: armcc command with no effect

make[1]: *** [main.o] Error 1
make: *** [all] Error 2

C:\Users\redacted\test\mbed-os-example-blinky>

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug

[theotherjimmy]

Yeah that's fixed by these commits: 881803c and 780352b

[ciarmcom]

ARM Internal Ref: MBOTRIAGE-1418

[0xc0170]

@theotherjimmy there are 3 PR that might have some dependencies (one is marked as needs preceding PR). Can you share how they should be integrated? Because I tried current master and make gcc and armc5 export. Fails for me (gcc: no input files error, armcc: command with no effect). I fetched 2 PR, here's my current mbed-os (if I checkout master, I get the same error as @cmonr reported above):

*   1a0a40817 - (HEAD -> theotherjimmy-make-armc6-v8m) Merge branch 'make-cmd-files' of https://github.com/theotherjimmy/mbed into theotherjimmy-make-armc6-v8m (4 minutes ago) <Martin Kojtal>
|\
| * 387747f8b - Implement Linker command/response files in make export (3 days ago) <Jimmy Brisson>
* |   544c2426c - Merge branch 'make-armc6-v8m' of https://github.com/theotherjimmy/mbed into theotherjimmy-make-armc6-v8m (11 minutes ago) <Martin Kojtal>
|\ \
| * | 780352b05 - Correct include paths in the face of abspaths (6 days ago) <Jimmy Brisson>
| * | 881803ca9 - Correct path handling after calls to `win_to_unix` (6 days ago) <Jimmy Brisson>
| * | 404e77074 - Revert "Disable make_armc6 on v8m" (6 days ago) <Jimmy Brisson>
| * | 6c7478dc8 - Quote Makefile CLI parameters (6 days ago) <Jimmy Brisson>
| * | c68b82538 - Use last linker script found (6 days ago) <Jimmy Brisson>
| * | afed6c1e5 - Migrate all flags into the FLAGS variables (6 days ago) <Jimmy Brisson>
* | |   b170e1c44 - (upstream/master, master) Merge pull request #7587 from SeppoTakalo/fix-tpcserver-warning (23 hours ago) <Martin Kojtal>

And I still can't build make gcc/armc5.

[theotherjimmy]

@0xc0170 That looks correct. I would like you to test the 544c2426c merge commit as well, if you get the chance.

[0xc0170]

on that commit 544c2426c

*   1cd80b0e7 - (HEAD -> master, upstream/master, theotherjimmy-make-cmd-files) Merge pull request #128 from adbridge/master (3 weeks ago) <Martin Kojtal>

mbed-os-example-blinky>make
mbed-os-example-blinky/makefile:1323: warning: overriding commands for target `.s.o'
mbed-os-example-blinky/makefile:1315: warning: ignoring old commands for target `.s.o'
Compile: main.cpp
arm-none-eabi-g++.exe: fatal error: no input files
compilation terminated.
make[1]: *** [main.o] Error 1
make: *** [all] Error 2

[theotherjimmy]

Yeah. I'm testing with the exceptionally slow windows cmd now. That's a quoting issue. The commits I mentioned do fix the problem, so I rebased them onto the other PR. That PR works, mostly.

[theotherjimmy]

see #7608

[cmonr]

Closing since the original regression is now fixed.

Other issues (#6335, #7129) remain open.