mbed-cli include issue

[AGlass0fMilk]

Description

Hi, I just upgraded to the most recent commit to master. When attempting to build, I am now getting errors saying #includes cannot be found.

I have custom build tools that work on top of mbed-cli. The way I accomplish my builds is by using the --source flag to specify additional include directories and libraries common to all my applications.

A command will look like this for example:

['mbed', 'compile', '--build=BUILD/debug', '--source=./', u'--source=/mbed-os', u'--source=/mbed-dsp', u'--source=/hud-core', '--source=../include', '--source=../common', u'--profile=/mbed-os/tools/profiles/debug.json']

This used to work fine (all the --source directories would be included in the build. But now the compiler isn't finding header files that reside in these directories...

Has anything changed recently with the build tool that would affect this?

Issue request type

[ ] Question
[ ] Enhancement
[ X ] Bug

[ciarmcom]

ARM Internal Ref: MBOTRIAGE-1328

[0xc0170]

My first suspect would be #7183

@ARMmbed/mbed-os-tools Please review

[cmonr]

@AGlass0fMilk Would you mind posting the output that you get?

Also, why are some of those strings prefixed with u, whereas others are not?

[AGlass0fMilk]

Well, the custom scripts are written in python and I use Popen to execute mbed compile. Popen recommends an input array so I form an array of command options. Printing out the array for verbose mode I guess python appends a u to indicate it's an array of unsigned chars or whatever.

EDIT: I will post output in a moment... virtual box is warming up...

[theotherjimmy]

@AGlass0fMilk We recently (in #7183) changed the behavior of include paths from "everything is an include path" to "paths to headers are include paths". You may be seeing that.

[theotherjimmy]

FYI, it saved ~30% of our include path file length when switching styles.

[AGlass0fMilk]

The problem I'm seeing is:
I have an 'include' directory for my product that has header files common to all the various programs (bootloader, main application, etc). The implementation for these headers are in a separate 'common' directory. These directories are alongside all the other program directories, similar to the following:

product
---> include
------> ble
------> ...
---> common
------> ble
------> ...
---> bootloader
---> main_application
---> factory_reset
.....

So I use the --source flag to include those common directories when building. Helps me keep my code a bit more organized. What do you recommend for this? The build script can't even find header files in the root of the 'include' directory.

[AGlass0fMilk]

FYI - This issue is related to something introduced after the recent mbed-os-5.9.3 release. I reverted to that release version and I can still build.

[theotherjimmy]

@AGlass0fMilk add --source=include. You already have it.

[theotherjimmy]

I'm glad that you're willing to test with master!

[theotherjimmy]

Let me see if I can reproduce this on master. BRB

[theotherjimmy]

@AGlass0fMilk For reproduction value, created the following structure:

..
├── blinky
│  └── <contents of mbed-os-example-blinky>
└── temp
   └── header.h

and modified main.cpp like so:

diff --git a/main.cpp b/main.cpp
index 2df9a05..73de4da 100644
--- a/main.cpp
+++ b/main.cpp
@@ -1,4 +1,5 @@
 #include "mbed.h"
+#include "header.h"
 
 DigitalOut led1(LED1);
 

ran the following command:

mbed2 compile --source=./ --source=../temp

(mbed2 is a bash alias for python2 -m mbed)
and it did not complain.

Does this simple reproducer cause the same error?